commit: fix compile errors, fix revert-buffer bug on binary/Latin 1 files, Mule-ize some files
ben at 666.com
Mon Feb 8 07:09:38 EST 2010
On Sun, Feb 7, 2010 at 9:46 PM, Vin Shelton <ethersoft at gmail.com> wrote:
> Ben -
> Thanks for fixing up the earlier build problems.
> Part of this patch isn't correct, tho -
> On Sun, Feb 7, 2010 at 8:12 AM, Ben Wing <ben at xemacs.org> wrote:
>> changeset: 5000:44d7bde26046
>> parent: 4994:76af7fc13e81
>> user: Ben Wing <ben at xemacs.org>
>> date: Sun Feb 07 05:21:40 2010 -0600
>> files: src/ChangeLog src/emacs.c src/fileio.c src/fns.c src/lisp.h src/nt.c
>> fix compile errors, fix revert-buffer bug on binary/Latin 1 files, Mule-ize some files
>> nr.dwScope = RESOURCE_GLOBALNET;
>> nr.dwType = RESOURCETYPE_DISK;
>> nr.dwDisplayType = RESOURCEDISPLAYTYPE_SERVER;
>> nr.dwUsage = RESOURCEUSAGE_CONTAINER;
>> nr.lpLocalName = NULL;
>> - PATHNAME_CONVERT_OUT (path, nr.lpRemoteName);
>> + PATHNAME_CONVERT_OUT (path, extpath);
>> + nr.lpRemoteName = (LPTSTR) extpath;
> Yields the following:
> C:\cygwin\usr\local\src\xemacs-21.5-test-2010-02-07\src\nt.c(966) :
> error C2440: '=' : cannot convert from 'char *' to 'unsigned short *'
> Types pointed to are unrelated; conversion requires
> reinterpret_cast, C-style cast or function-style cast
> Changing the cast from LPTSTR to unsigned short * shuts up the
> compiler, but I don't know if you want a different type there. Please
> fix this.
> Thank you,
It should be XELPTSTR and I've committed it this way. Hopefully it'll work now.
Sorry about these problems. I don't have Visual C++ on my current
machine so I'm relegated to using Cygwin, which doesn't catch quite
the same things as VC++.
More information about the XEmacs-Patches