Stephen J. Turnbull
stephen at xemacs.org
Sun Apr 1 23:57:26 EDT 2007
Olivier Galibert writes:
> On Sun, Apr 01, 2007 at 11:53:12PM +0900, Stephen J. Turnbull wrote:
> > That said, there are two issues that I'd like insight into (no effect
> > on your patch, as they apply to the original version too). (They're
> > flagged with #### in the patch below.)
> > 1. I wonder if there might be efficiency implications to the
> > alignment of text_storage, since in many cases we'll be storing
> > shorts or integers into it.
> Or correctness even. I don't know is libXft is unaligned-resistant.
You mean on platforms where you get bus errors if the alignment of an
access is incorrect? Urk. OK, I'll leave the #### there.
> > Also, I'd like to suggest the patch below (to be applied *on top of*
> > your patch).
> I like it.
OK, I think you can apply your patch, and once I've negotiated some
wording with Aidan, I plan to apply mine.
More information about the XEmacs-Patches