CVS update by aidan xemacs/src ...

[xemacs-cvs at xemacs.org]

  User: aidan   
  Date: 06/10/27 21:07:51

  Modified:    xemacs/src ChangeLog fileio.c
Log:
Deal with buffer-reversion with non-binary coding better; update fileio.c
comment from Ben.

Revision  Changes    Path
1.762     +6 -0      XEmacs/xemacs/lisp/ChangeLog

Index: ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/ChangeLog,v
retrieving revision 1.761
retrieving revision 1.762
diff -u -p -r1.761 -r1.762
--- ChangeLog	2006/10/15 00:50:50	1.761
+++ ChangeLog	2006/10/27 19:07:32	1.762
@@ -1,3 +1,9 @@
+2006-10-27  Aidan Kehoe  <kehoea at parhasard.net>
+
+	* files.el (revert-buffer-internal):
+	When reverting, use the buffer-file-coding-system of the file's
+	buffer when determing whether something has changed on disk. 
+	
 2006-10-14  Jeff Miller  <jmiller at xemacs.org>
 
         * info.el (Info-find-emacs-command-nodes): fix regex for find



1.76      +4 -1      XEmacs/xemacs/lisp/files.el

Index: files.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/files.el,v
retrieving revision 1.75
retrieving revision 1.76
diff -u -p -r1.75 -r1.76
--- files.el	2005/11/13 07:39:29	1.75
+++ files.el	2006/10/27 19:07:33	1.76
@@ -3521,7 +3521,10 @@ Return nil if identical, and the new buf
 	      after-change-function
 	      after-change-functions
 	      before-change-function
-	      before-change-functions)
+	      before-change-functions
+	      ;; #### b-f-c-s is _not necessarily_ the coding system that
+	      ;; was used to read in the file. See its docstring.
+	      (coding-system-for-read buffer-file-coding-system))
 	  (if revert-buffer-insert-file-contents-function
 	      (funcall revert-buffer-insert-file-contents-function
 		       file-name nil)



1.1001    +7 -0      XEmacs/xemacs/src/ChangeLog

Index: ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/ChangeLog,v
retrieving revision 1.1000
retrieving revision 1.1001
diff -u -p -r1.1000 -r1.1001
--- ChangeLog	2006/08/29 14:10:51	1.1000
+++ ChangeLog	2006/10/27 19:07:45	1.1001
@@ -1,3 +1,10 @@
+2006-10-27  Aidan Kehoe  <kehoea at parhasard.net>
+
+	* fileio.c (Finsert_file_contents_internal) : Clarify that we
+	follow a more correct but more expensive design for buffers where
+	the on-disk representation doesn't correspond directly to the
+	XEmacs internal representation. 
+
 2006-08-29  Stephen J. Turnbull  <stephen at xemacs.org>
 
 	* eval.c (Fcatch): Correct syntax of `throw' in docstring.



1.106     +7 -0      XEmacs/xemacs/src/fileio.c

Index: fileio.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/fileio.c,v
retrieving revision 1.105
retrieving revision 1.106
diff -u -p -r1.105 -r1.106
--- fileio.c	2006/06/19 18:19:37	1.105
+++ fileio.c	2006/10/27 19:07:47	1.106
@@ -2948,6 +2948,13 @@ under Mule, is very difficult.)
      reasonable maximum file size on the files.  Is any of this worth it?
      --ben
 
+
+       It's probably not worth it, and despite what you might take from the
+       above, we don't do it currently; that is, for non-"binary" coding
+       systems, we don't try to implement replace-mode at all. See the
+       do_speedy_insert variable above. The upside of this is that our API
+       is consistent and not buggy. -- Aidan Kehoe, Fri Oct 27 21:02:30 CEST
+       2006
      */
 
   if (!NILP (replace))