[COMMIT] Apply Stephen's bugfix to my advice.el changes

[Mats Lidell]

>>>>> Stephen J Turnbull <stephen at xemacs.org> writes:

Stephen> Aidan has a better grasp of details than I do, read his
Stephen> posts.  I think there's still a puzzle piece missing,
Stephen> specifically it seems that the order of the instantiators
Stephen> matters.

Well I will try to read both of your posts again. 

Just a quick report here that the patch aidan supplied made the 21.5
build pass when run in a debug environment. (a copy of the smoktest
setup on the same machine.)

Stephen> I think that what is probably happening is that XEmacs is
Stephen> being run as a subprocess of some program that doesn't close
Stephen> unneeded file descriptors before forking XEmacs -- and then
Stephen> does close them later.  Why this hasn't been a problem in the
Stephen> past I'm not sure; perhaps it has to do with multicore
Stephen> architectures becoming common.

Interesting idea. In fact the current machine is a virtual thing with
just one CPU assigned. The old server was a multi CPU thing. Maybe
there is some limit when run through cron that isn't there when run in
a login shell!?

Stephen> Eg, are you perhaps running make -j N for N > 1?

No. I haven't taken that bold step yet. I have assumed that the
makefiles for the smoketest isn't prepared for that. (And on the
current machine would do much good either.)

Yours
-- 
%% Mats