Unused structure fields & enum values, and prototypes with no def
james at xemacs.org
Thu Sep 16 13:28:15 EDT 2004
I'm still working on getting Uno up to speed on checking our sources.
We're allllmmooooossssstttt there. It's still doing some funny stuff
with the comma operator and with function types declared in parameter
lists, and some internal buffer I haven't located yet is overflowing in
the global property checker. But that's a short list compared to what
has been fixed already. :-)
Here's the latest news from Uno, though: a list of structure fields and
enum values that don't appear to be used anywhere, with a few prototypes
with no matching functions thrown in for good measure. If anybody knows
anything about any of these, please speak up. In particular, should we
get rid of or comment out any of them?
charset.h:228, unicode_table_loaded in struct Lisp_Charset
console-impl.h:164, frame_redraw_cursor_method in struct console_methods
console-impl.h:233, resize_subwindow_method in struct console_methods
Note that this one is set for Windows in glyphs-msw.c (see
Fresize_subwindow), but doesn't appear to be *used* anywhere.
glyphs.h:91, IMAGE_GEOMETRY, IMAGE_MIN_GEOMETRY, and IMAGE_MAX_GEOMETRY
in enum image_instance_geometry
lrecord.h:196, lrecord_type_popup_data in enum lrecord_type
lisp.h:3641-3647, enum arith_comparison
lisp.h:3648, function prototype arithcompare
lisp.h:3984&3986, OPERATION_CREATE_OBJECT and
OPERATION_MODIFY_OBJECT_PROPERTY in enum check_allowed_operation
EmacsShell.c is using the system assert (/usr/include/assert.h) instead
of the assert used everywhere else (see lisp.h).
There's more, but that's all I have time to deal with right now.
More information about the XEmacs-Beta