[Failure] XEmacs 21.5-b17 "chayote" (+CVS-20040913) i586-pc-win32

[Jerry James]

Adrian Aichner <adrian at xemacs.org> wrote:
> Hi Jerry!

Hi Adrian!

> After updating from CVS at
> Compilation started at Tue Sep 14 22:51:55 2004 +0200 (W. Europe Daylight Time)
> I get following build error.

Okay, I see it.  The DECLARE_DOESNT_RETURN macro has never been used
with a declaration having the "extern" storage class before.  On
Windows, DECLARE_DOESNT_RETURN expands to a form containing "extern".  I
would rather remove that "extern", but I don't know what effect that
might have.  I'll take the safe tack of removing the "extern" from the
two declarations the Microsoft compiler was complaining about.  If you
happen to know why the "extern" is in the Windows DECLARE_DOESNT_RETURN,
I would appreciate being filled in.


src/ChangeLog addition:

2004-09-14  Jerry James  <james at xemacs.org>

	* gifrlib.h: Remove redundant extern declarations.


xemacs-21.5 source patch:
Diff command:   cvs -q diff -uN
Files affected: src/gifrlib.h

Index: src/gifrlib.h
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/gifrlib.h,v
retrieving revision 1.6
diff -d -u -r1.6 gifrlib.h
--- src/gifrlib.h	2004/09/14 14:32:50	1.6
+++ src/gifrlib.h	2004/09/15 04:17:33
@@ -145,11 +145,9 @@
 ******************************************************************************/
 extern void GifSetErrorFunc(GifFileType *GifFile, Gif_error_func func, VoidPtr data);
 extern void GifSetWarningFunc(GifFileType *GifFile, Gif_error_func func, VoidPtr data);
-extern DECLARE_DOESNT_RETURN (GifInternError(GifFileType *GifFile,
-					     int errnum));
+DECLARE_DOESNT_RETURN (GifInternError(GifFileType *GifFile, int errnum));
 extern void GifInternWarning(GifFileType *GifFile, int errnum);
-extern DECLARE_DOESNT_RETURN (GifError(GifFileType *GifFile,
-				       const char *err_str));
+DECLARE_DOESNT_RETURN (GifError(GifFileType *GifFile, const char *err_str));
 extern void GifWarning(GifFileType *GifFile, const char *err_str);
 
 /*****************************************************************************

-- 
Jerry James
http://www.ittc.ku.edu/~james/