Xft patch 11/17/2004
ben at 666.com
Thu Nov 18 22:08:01 EST 2004
I've browsed through this patch. A few comments:
-- could you redo the indentation to follow XEmacs coding standards?
Basically this means
[a] open-braces need to be on a separate line
[b] you need a space before the open-paren for all function and macro calls
[c] use ####, not FIXME
-- in redisplay.c you seem to have put back some text I deleted and moved to
the Internals manual.
-- I'd rather see separate_textual_runs() factored out than duplicated.
-- more generally: Do we really need all these xft-* primitives? It seems
rather questionable. In XEmacs we try consistently to hide device-specific
API's behind device-independent abstractions, and this completely breaks
this. If you need to provide a way to specify the properties of a font
independently of each other, then you should extend the general
device-independent interface to do this: Certainly this would be useful for
other kinds of fonts. Even if you aren't actually able to implement the
device-specific versions for MS Windows, GTK, etc. at least put the
framework in place.
More information about the XEmacs-Beta