[AC21.5] Arithmetic and tag failures with 'make check'.

[Jerry James]

Malcolm Purvis <malcolmp at xemacs.org> wrote:
> With a bleeding edge CVS of 21.5, configured with:
>
> ../../sandboxen/xemacs-head/configure --prefix=/usr/local/gcc3-world
> --package-path=/usr/local/lib/xemacs --with-gnome 
>
> and running on PPC Linux (YellowDog 2.3, sort of Redhat 7.3 for PPC) I'm
> getting the following test failures:
>
> Testing /home/malcolmp/builds/xemacs/sandboxen/xemacs-head/tests/automated/lisp-tests.el...
> FAIL: Assertion failed: (eql (% x -17) (- (% (- x) 17))); failing case = -1073741824
> FAIL: Assertion failed: (eql (% x -17) (- (% (- x) 17))); failing case = -1073741824

Oops.  Slap me around a little.  My last patch to lisp-tests.el only fixed
half of the problem.  Here's the other half.


tests/ChangeLog addition:

2004-05-13  Jerry James  <james at xemacs.org>

	* automated/lisp-tests:el: Another test fix because
	(eq most-negative-fixnum (- most-negative-fixnum)).


xemacs-21.5 source patch:
Diff command:   cvs -q diff -uN
Files affected: tests/automated/lisp-tests.el

Index: tests/automated/lisp-tests.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/tests/automated/lisp-tests.el,v
retrieving revision 1.6
diff -d -u -r1.6 lisp-tests.el
--- tests/automated/lisp-tests.el	2004/05/03 15:08:51	1.6
+++ tests/automated/lisp-tests.el	2004/05/13 15:25:08
@@ -504,12 +504,15 @@
 (flet ((test1 (x) (Assert (eql x (+ (% x 17) (* (/ x 17) 17))) x))
        (test2 (x) (Assert (eql (- x) (+ (% (- x) 17) (* (/ (- x) 17) 17))) x))
        (test3 (x) (Assert (eql x (+ (% (- x) 17) (* (/ (- x) 17) 17))) x))
-       (test4 (x) (Assert (eql (% x -17) (- (% (- x) 17))) x)))
+       (test4 (x) (Assert (eql (% x -17) (- (% (- x) 17))) x))
+       (test5 (x) (Assert (eql (% x -17) (% (- x) 17))) x))
   (test1 most-negative-fixnum)
   (if (featurep 'bignum)
-      (test2 most-negative-fixnum) 
-    (test3 most-negative-fixnum))
-  (test4 most-negative-fixnum)
+      (progn
+	(test2 most-negative-fixnum)
+	(test4 most-negative-fixnum))
+    (test3 most-negative-fixnum)
+    (test5 most-negative-fixnum))
   (test1 most-positive-fixnum)
   (test2 most-positive-fixnum)
   (test4 most-positive-fixnum)

-- 
Jerry James
http://www.ittc.ku.edu/~james/