Is flush-lines a performance boar in 21.5-b17

[Jerry James]

Adrian Aichner <adrian at xemacs.org> wrote:
> I am also getting an error during display of profiling results:
>
> Signaling: (invalid-function (macro . #<compiled-function (name &rest body) "...(32)" [body name let* (winconfig (current-window-configuration)) (was-one-window (one-window-p)) buffer-name ((help-not-visible (not (and (windows-of-buffer buffer-name) (memq (selected-frame) (mapcar (quote window-frame) (windows-of-buffer buffer-name))))))) (help-register-and-maybe-prune-excess buffer-name) (if (and help-sticky-window (or (not (windowp help-sticky-window)) (not (window-live-p help-sticky-window)))) (setq help-sticky-window nil)) prog1 let ((temp-buffer-show-function (if help-sticky-window (function (lambda (buffer) (set-window-buffer help-sticky-window buffer))) temp-buffer-show-function))) with-output-to-temp-buffer progn ((save-excursion (set-buffer standard-output) (funcall mode-for-temp-buffer))) ((let ((helpwin (get-buffer-window buffer-name))) (when helpwin (when help-not-visible (with-current-buffer (window-buffer helpwin) (setq help-window-config winconfig))) (when he!
 lp!
>  -selects-help-window (select-window helpwin)) (cond ((eq helpwin (selected-window)) (display-message (quote command) (substitute-command-keys "Type \\[help-mode-quit] to remove window, \\[scroll-up] to scroll the text."))) (was-one-window (display-message (quote command) (substitute-command-keys "Type \\[delete-other-windows] to remove window, \\[scroll-other-window] to scroll the text."))) (t (display-message (quote command) (substitute-command-keys "Type \\[switch-to-buffer-other-window] to restore the other window, \\[scroll-other-window] to scroll the text.")))))))] 12 1031891>))
>   with-displaying-temp-buffer("*Profiling Results*" nil)
>   profile-results()
>   profile-command(ibuffer nil)
>   call-interactively(profile-command)
>   command-execute(profile-command t)
>   execute-extended-command(nil)
>   call-interactively(execute-extended-command)

Steve Youngs also reported that calls to with-displaying-temp-buffer
were resulting an an invalid-function error:

http://list-archive.xemacs.org/xemacs-beta/200403/msg00052.html

The call, in profile-results, is coming from the packages, namely
xemacs-packges/xemacs-devel/profile.el.  The with-displaying-temp-buffer
macro is defined in core, namely in lisp/help.el.  The problem is that
that macro exists in the 21.5 tree only.  So if your packages are built
with 21.4, you don't have the macro definition at compile time, and this
error will occur.  Sure enough, a trip to Mats' smoketest page and a
search through the 21.4 Mule build log shows this:

------------------------------------------------------------------------
Compiling /home/matsl/work/smoketest/build/packages/xemacs-packages/xemacs-devel/profile.el...
While compiling the end of the data in file /home/matsl/work/smoketest/build/packages/xemacs-packages/xemacs-devel/profile.el:
  ** the function with-displaying-temp-buffer is not known to be defined.
Wrote /home/matsl/work/smoketest/build/packages/xemacs-packages/xemacs-devel/profile.elc
------------------------------------------------------------------------

I'm not seeing this