[Bug: 21.4.12] [PATCH] dired-summary doesn't understand keys like [d]

[Jouni K Seppanen]

================================================================
Dear Bug Team!

The function dired-summary used to display a command summary like
d-elete, u-ndelete, x-punge, f-ind, o-ther window, R-ename, C-opy, h-elp
However, now I get
d delete, u undelete, x expunge, f find. o other window, R rename, C copy, M-? m help

The problem seems to be that, e.g., 
(where-is-internal 'dired-flag-file-deletion dired-mode-map)
returns ([d]), not ("d"), and dired-summary does (member "d" ...) to
check if "d" is a key for the deletion command. Here is a suggested
fix:

(defun dired-summary ()
  "Display summary of basic dired commands in the minibuffer."
  (interactive)
  (message
   (mapconcat
    #'(lambda (list)
        (let* ((cmd (nth 0 list))
               (letter (nth 1 list))
               (name (nth 2 list))
               (name-with-letter (nth 3 list))
               (where-is (where-is-internal cmd dired-mode-map)))
          (if (or (member letter where-is)
                  (member (vector (intern letter)) where-is))
              name-with-letter
            (substitute-command-keys
             (format "\\<dired-mode-map>\\[%s] %s" cmd name)))))
    '((dired-flag-file-deletion     "d" "delete"       "d-elete")
      (dired-unmark                 "u" "undelete"     "u-ndelete")
      (dired-expunge-deletions      "x" "expunge"      "x-punge")
      (dired-advertised-find-file   "f" "find"         "f-ind")
      (dired-find-file-other-window "o" "other window" "o-ther window")
      (dired-do-rename              "R" "rename"       "R-ename")
      (dired-do-copy                "C" "copy"         "C-opy")
      (dired-describe-mode          "h" "help"         "h-elp"))
    ", ")))

================================================================

System Info to help track down your bug:
---------------------------------------

uname -a: Linux eeyore 2.4.20-pre8-ac2 #1 Mon Sep 30 14:56:10 EDT 2002 i686 unknown unknown GNU/Linux

./configure  '--with-sound=none,native' '--cflags=-O2 -Wall' '--with-x11' '--extra-verbose' '--with-site-lisp' '--statedir=/var/lib' '--infodir=/usr/share/info/xemacs-21.4.12' '--prefix=/usr' '--error-checking=none' '--debug=no' '--dynamic' '--with-pop' '--with-gpm=no' '--with-file-coding' '--pdump' '--with_menubars=lucid' '--with_scrollbars=lucid' '--with_dialogs=athena' '--docdir=/usr/lib/xemacs-21.4.12/i386-debian-linux/mule/' '--with-mule' '--with-canna=no' '--with-wnn=no' '--with-xim=xlib' '--with-xfs' '--package-path=~/.xemacs:~/.xemacs/packages:~/.xemacs/xemacs-packages::/usr/share/xemacs21/packages:/usr/share/xemacs21/mule-packages:/usr/share/xemacs21/site-packages' 'i386-debian-linux'


XEmacs 21.4.12 "Portable Code" configured for `i386-debian-linux'.


Compilation / Installation:
  Source code location:              /home/dres/project/debian/current/xemacs21/xemacs-21.4.12
  Installation prefix:               /usr
  Operating system description file: `s/linux.h'
  Machine description file:          `m/intel386.h'
  Compiler:                          gcc -O2 -Wall
  Relocating allocator for buffers:  no
  GNU version of malloc:             yes
    - Using Doug Lea's new malloc from the GNU C Library.

Window System:
  Compiling in support for the X window system:
    - X Windows headers location:                 /usr/X11R6/include
    - X Windows libraries location:               /usr/X11R6/lib
    - Handling WM_COMMAND properly.
  Compiling in support for the Athena widget set:
    - Athena headers location:                    X11/Xaw
    - Athena library to link:                     Xaw
  Using Lucid menubars.
  Using Lucid scrollbars.
  Using Athena dialog boxes.
  Using Athena native widgets.

TTY:
  Compiling in support for ncurses.

Images:
  Compiling in support for GIF  images (builtin).
  Compiling in support for XPM  images.
  Compiling in support for PNG  images.
  Compiling in support for JPEG images.
  Compiling in support for TIFF images.
  Compiling in support for X-Face message headers.

Sound:
  Compiling in support for sound (native).

Databases:
  Compiling in support for Berkeley database.
  Compiling in support for LDAP.
  Compiling in support for PostgreSQL.
    - Using PostgreSQL header file:  postgresql/libpq-fe.h
    - Using PostgreSQL V7 bindings.

Internationalization:
  Compiling in support for Mule (multi-lingual Emacs).
  Compiling in support for file coding.
  Compiling in support for XIM (X11R5+ I18N input method).
    - Using raw Xlib to provide XIM support.
    - Using XFontSet to provide bilingual menubar.

Mail:
  Compiling in support for POP mail retrieval.
  Compiling in support for "dot-locking" mail spool file locking method.

Other Features:
  Inhibiting IPv6 canonicalization at startup.
  Compiling in support for dynamic shared object modules.
  Using the new portable dumper.


[...]

 (dired :version 1.13 :type regular)

[...]