[Failure] XEmacs 21.5-b17 "chayote" (+CVS-20040415) i586-pc-win32

[James C. McPherson]

Stephen J. Turnbull wrote:
>>>>>>"APA" == Adrian Aichner <Adrian.Aichner at t-online.de> writes:
>     APA> The trunk no longer builds on native Windows.
> That would be Olivier's dumpfile-in-executable patch.

Well that's just fine and dandy, but xemacs cvs (18-apr-2004) is
no longer building for me, dying in the same place:


emacs.c: (831-835)
---------------------------------------------
#if defined(PDUMP) || !defined(WIN32_NATIVE)
	printf ("%d %d\n", dumped_data_max_size(), dumped_data_align_offset());
#else
       printf ("Portable dumper not configured or windows native; -si 
just forces exit.\n");
#endif
---------------------------------------------


Now given that I've run configure with "--pdump=no" and
I'm most definitely not running ms-windows, shouldn't
this be a "&&" instead of "||" ?

And really, shouldn't we also have the comparison around the
other way too? Something like



#if defined(WIN32_NATIVE) || !defined(PDUMP)
	printf ("Portable dumper not configured or windows native; -si just 
forces exit.\n");
#else
      	printf ("%d %d\n", dumped_data_max_size(), 
dumped_data_align_offset());
#endif


best regards,
James C. McPherson