10:58 a.m.
Gnus users, have you seen this error?
itimer "with-timeout" signaled: (no-catch (nil) timeout)
There is a bug in `with-timeout' macro, when BODY is executed
successfuly intime, timeout handler is not destroyed and executed
lately outside the catch, giving no-catch error .. this patch fixes
this ..
----------------- cut here -----------------
--- timer-funcs.el~ Fri Oct 22 19:23:09 2004
+++ timer-funcs.el Fri Nov 18 13:20:01 2005
＠＠ -181,16 +181,18 ＠＠
(timeout-forms (cdr list)))
`(let ((with-timeout-tag (cons nil nil))
with-timeout-value with-timeout-timer)
- (when (catch with-timeout-tag
- (progn
- (setq with-timeout-timer
- (start-itimer "with-timeout" #'with-timeout-handler
- ,seconds nil nil t with-timeout-tag))
- (setq with-timeout-value (progn ,＠body))
- nil))
- ,＠timeout-forms
- (delete-itimer with-timeout-timer)
- with-timeout-value))))
+ (when (catch with-timeout-tag
+ (progn
+ (setq with-timeout-timer
+ (start-itimer "with-timeout" #'with-timeout-handler
+ ,seconds nil nil t with-timeout-tag))
+ (setq with-timeout-value
+ (unwind-protect
+ (progn ,＠body)
+ (delete-itimer with-timeout-timer)))
+ nil))
+ ,＠timeout-forms
+ with-timeout-value))))
;;;###autoload
(defun y-or-n-p-with-timeout (prompt seconds default-value)
----------------- cut ends here -----------------
Thanks!
--
lg
12:08 a.m.
New subject: [Q] Re: PATCH [packages(xemacs-base)] -- `with-timeout' bug fix
QUERY
* Zajcev Evgeny <zevlg(a)yandex.ru> writes:
Gnus users, have you seen this error?
itimer "with-timeout" signaled: (no-catch (nil) timeout)
There is a bug in `with-timeout' macro, when BODY is executed
successfuly intime, timeout handler is not destroyed and executed
lately outside the catch, giving no-catch error .. this patch fixes
this ..
Hi Evgeny!
I'm pretty sure this was fixed in...
,----
| 2005-10-11 Steve Youngs <steve(a)sxemacs.org>
|
| * timer-funcs.el (with-timeout): Use `unwind-protect' to ensure
| the timer is always deleted.
| From: tbennett(a)nvidia.com
|
`----
It is in xemacs-base package version 1.99 and above. Here is the
current `with-timeout'...
,----
| (defmacro with-timeout (list &rest body)
| "Run BODY, but if it doesn't finish in SECONDS seconds, give up.
| If we give up, we run the TIMEOUT-FORMS and return the value of the last one.
| The call should look like:
| (with-timeout (SECONDS TIMEOUT-FORMS...) BODY...)
| The timeout is checked whenever XEmacs waits for some kind of external
| event \(such as keyboard input, input from subprocesses, or a certain time);
| if the program loops without waiting in any way, the timeout will not
| be detected."
| (let ((seconds (car list))
| (timeout-forms (cdr list)))
| `(let ((with-timeout-tag (cons nil nil))
| with-timeout-value with-timeout-timer)
| (unwind-protect
| (when (catch with-timeout-tag
| (progn
| (setq with-timeout-timer
| (start-itimer "with-timeout" #'with-timeout-handler
| ,seconds nil nil t with-timeout-tag))
| (setq with-timeout-value (progn ,＠body))
| nil))
| ,＠timeout-forms
| with-timeout-value)
| (delete-itimer with-timeout-timer)))))
`----
...does it not work for you?
--
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
| I am Dyslexic of Borg. |
| Fusistance is retile. Your arse will be laminated. |
|------------------------------------<steve(a)sxemacs.org>---|
12:41 a.m.
New subject: [Q] Re: PATCH [packages(xemacs-base)] -- `with-timeout' bug fix
Steve Youngs <steve(a)sxemacs.org> writes:
[..]
,----
| 2005-10-11 Steve Youngs <steve(a)sxemacs.org>
|
| * timer-funcs.el (with-timeout): Use `unwind-protect' to ensure
| the timer is always deleted.
| From: tbennett(a)nvidia.com
|
`----
It is in xemacs-base package version 1.99 and above. Here is the
current `with-timeout'...
,----
| (defmacro with-timeout (list &rest body)
| "Run BODY, but if it doesn't finish in SECONDS seconds, give up.
| If we give up, we run the TIMEOUT-FORMS and return the value of the last one.
| The call should look like:
| (with-timeout (SECONDS TIMEOUT-FORMS...) BODY...)
| The timeout is checked whenever XEmacs waits for some kind of external
| event \(such as keyboard input, input from subprocesses, or a certain time);
| if the program loops without waiting in any way, the timeout will not
| be detected."
| (let ((seconds (car list))
| (timeout-forms (cdr list)))
| `(let ((with-timeout-tag (cons nil nil))
| with-timeout-value with-timeout-timer)
| (unwind-protect
| (when (catch with-timeout-tag
| (progn
| (setq with-timeout-timer
| (start-itimer "with-timeout" #'with-timeout-handler
| ,seconds nil nil t with-timeout-tag))
| (setq with-timeout-value (progn ,＠body))
| nil))
| ,＠timeout-forms
| with-timeout-value)
| (delete-itimer with-timeout-timer)))))
`----
...does it not work for you?
No, it work! However i was not having this version of `with-timeout'
in sumo packages i've downloaded recently, so i decided that this
question is open .. sorry for disturbing water
This version works very well thanks!
--
lg
1:33 a.m.
New subject: [Q] Re: PATCH [packages(xemacs-base)] -- `with-timeout' bug fix
* Zajcev Evgeny <zevlg(a)yandex.ru> writes:
Steve Youngs <steve(a)sxemacs.org> writes:
[..]
>
> ,----
> | 2005-10-11 Steve Youngs <steve(a)sxemacs.org>
> |
> | * timer-funcs.el (with-timeout): Use `unwind-protect' to ensure
> | the timer is always deleted.
> | From: tbennett(a)nvidia.com
> |
> `----
[...]
> ...does it not work for you?
No, it work! However i was not having this version of
`with-timeout'
in sumo packages i've downloaded recently, so i decided that this
question is open .. sorry for disturbing water
Hehe, that's cool. When you find probs in packages it's best to check
the code in CVS before you start hacking. :-)
--
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
| I am Dyslexic of Borg. |
| Fusistance is retile. Your arse will be laminated. |
|------------------------------------<steve(a)sxemacs.org>---|
7003
days inactive
7004
days old
3 comments
2 participants
participants (2)
-
Steve Youngs -
Zajcev Evgeny