8:05 a.m.
21.4 (already in 21.5)
This patch adds line-beginning-position and line-end-position to the
21.4 series. We've seen these being erratically used here and there in
packages a few times and lisp things out there outside of the packages
tree uses these functions pretty often, I guess they're thought of as
ubiquitous by many.
The latest problem due to lack of these functions I'm aware of was
reported as https://bugzilla.redhat.com/192481 : the current
haskell-mode's indentation is broken on 21.4.
Jerry, in case you're around, it could be a good idea to fix
haskell-*indent.el to not use line-(beginning|end)-position in the
meantime.
8:42 a.m.
>>>> "Ville" == Ville Skyttä
<scop(a)xemacs.org> writes:
Ville> Jerry, in case you're around, it could be a good idea to
Ville> fix haskell-*indent.el to not use
Ville> line-(beginning|end)-position in the meantime.
Jerry isn't likely to be around until August, cf thread on XEmacs
Review.
If you would like to submit a patch, I'll review it if you like (I
guess the main issue will be synchs to Stefan's mainline) or you can
just commit if you think it's "obviously correct". I'll take
responsibility for following up bugs unless somebody else wants to
claim it.
Steve
--
School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
11:38 a.m.
New subject: [PATCH pkgs (haskell-mode)] Don't use line-beginning-position, line-end-position
On Sat, 2006-05-20 at 16:42 +0900, Stephen J. Turnbull wrote:
>>>>> "Ville" == Ville Skyttä
<scop(a)xemacs.org> writes:
Ville> Jerry, in case you're around, it could be a good idea to
Ville> fix haskell-*indent.el to not use
Ville> line-(beginning|end)-position in the meantime.
Jerry isn't likely to be around until August, cf thread on XEmacs
Review.
Yep, I saw the thread but forgot about the datespan.
If you would like to submit a patch, I'll review it if you like
(I
guess the main issue will be synchs to Stefan's mainline) or you can
just commit if you think it's "obviously correct". I'll take
responsibility for following up bugs unless somebody else wants to
claim it.
Thanks. Patch attached, not really tested apart from compiling the
patched package; more eyes can't hurt so it'd be cool if you could
review it (and feel free to commit if you think it's ok or let me know
and I'll do it).
5:14 p.m.
New subject: [A pkgs (haskell-mode)] Don't use line-beginning-position, line-end-position
APPROVE pkgs (haskell-mode)
Ville Skyttä <scop(a)xemacs.org> wrote:
Thanks. Patch attached, not really tested apart from compiling the
patched package; more eyes can't hurt so it'd be cool if you could
review it (and feel free to commit if you think it's ok or let me know
and I'll do it).
Please go ahead and commit this, Ville.
--
Jerry James, Assistant Professor james(a)xemacs.org
Computer Science Department http://www.cs.usu.edu/~jerry/
Utah State University
6:53 p.m.
New subject: [C pkgs (haskell-mode)] Don't use line-beginning-position, line-end-position
COMMIT pkgs (haskell-mode)
On Wed, 2006-05-24 at 10:14 -0600, Jerry James wrote:
APPROVE pkgs (haskell-mode)
Ville Skyttä <scop(a)xemacs.org> wrote:
> Thanks. Patch attached, not really tested apart from compiling the
> patched package; more eyes can't hurt so it'd be cool if you could
> review it (and feel free to commit if you think it's ok or let me know
> and I'll do it).
Please go ahead and commit this, Ville.
Done, thanks for the review and welcome back!
5:13 p.m.
"Stephen J. Turnbull" <stephen(a)xemacs.org> wrote:
Jerry isn't likely to be around until August, cf thread on
XEmacs
Review.
Reports of my absence have been greatly exaggerated. :-)
I seem to be recovering pretty well, although the pain medication has
left me a bit loopy. Thanks for covering for me Ville and Steve.
--
Jerry James, Assistant Professor james(a)xemacs.org
Computer Science Department http://www.cs.usu.edu/~jerry/
Utah State University
2:24 p.m.
New subject: [AC21.4] Add line-beginning-position, line-end-position
Approve Commit 21.4
Thanks for the patch, Ville. It will appear in the 21.4.20 release.
- Vin
Ville Skyttä <scop(a)xemacs.org> writes:
21.4 (already in 21.5)
This patch adds line-beginning-position and line-end-position to the
21.4 series. We've seen these being erratically used here and there in
packages a few times and lisp things out there outside of the packages
tree uses these functions pretty often, I guess they're thought of as
ubiquitous by many.
The latest problem due to lack of these functions I'm aware of was
reported as https://bugzilla.redhat.com/192481 : the current
haskell-mode's indentation is broken on 21.4.
Jerry, in case you're around, it could be a good idea to fix
haskell-*indent.el to not use line-(beginning|end)-position in the
meantime.
6754
days inactive
6799
days old
6 comments
4 participants
participants (4)
-
Jerry James -
Stephen J. Turnbull -
Ville Skyttä -
Vin Shelton