APPROVE COMMIT NOTE: This patch has been committed # HG changeset patch # User Aidan Kehoe <kehoea(a)parhasard.net&gt; # Date 1506778279 -3600 # Sat Sep 30 14:31:19 2017 +0100 # Node ID e183dc2a264ece3c1fa543b7d8665592d444a7da # Parent 3cbfc9e40cf7617b4d15b5bc913c3c1dd12e2516 Only call #'test-chars when running byte-compiled, mule-tests.el 2017-09-30 Aidan Kehoe <kehoea(a)parhasard.net&gt; * automated/extent-tests.el: Update check for varying-length case transformation to work following the unicode-internal merge, LATIN CAPITAL LETTER I WITH DOT ABOVE may be from a distinct charset on old-mule. * automated/lisp-tests.el: Really don't check whether #'auto-save-escape-name always creates a new string, now it doesn't. * automated/mule-tests.el (test-chars): Update the docstring of this function. Only call it when the tests are running byte-compiled. diff -r 3cbfc9e40cf7 -r e183dc2a264e tests/ChangeLog --- a/tests/ChangeLog Sat Sep 30 11:21:05 2017 +0100 +++ b/tests/ChangeLog Sat Sep 30 14:31:19 2017 +0100 ＠＠ -7,7 +7,10 ＠＠ * automated/lisp-tests.el: Really don't check whether #'auto-save-escape-name always creates a new string, now it doesn't. - + * automated/mule-tests.el (test-chars): + Update the docstring of this function. Only call it when the tests + are running byte-compiled. + 2017-09-24 Aidan Kehoe <kehoea(a)parhasard.net&gt; * automated/lisp-tests.el: diff -r 3cbfc9e40cf7 -r e183dc2a264e tests/automated/mule-tests.el --- a/tests/automated/mule-tests.el Sat Sep 30 11:21:05 2017 +0100 +++ b/tests/automated/mule-tests.el Sat Sep 30 14:31:19 2017 +0100 ＠＠ -41,9 +41,10 ＠＠ (defun test-chars (&optional for-test-harness) "Insert all characters in a buffer, to see if XEmacs will crash. -This is done by creating a string with all the legal characters -in [0, 2^21) range, inserting it into the buffer, and checking -that the buffer's contents are equivalent to the string. +This is done by creating a string with all the legal characters +\(see the documentation for the variable `char-code-limit' and the function +`char-int'), inserting it into the buffer, and checking that the buffer's +contents are equivalent to the string. If FOR-TEST-HARNESS is specified, a temporary buffer is used, and the Assert macro checks for correctness." ＠＠ -73,11 +74,9 ＠＠ (insert string) (assert (equal (buffer-string) string)))))) -;; It would be really *really* nice if test-harness allowed a way to -;; run a test in byte-compiled mode only. It's tedious to have -;; time-consuming tests like this one run twice, once interpreted and -;; once compiled, for no good reason. -(test-chars t) +;; Run #'test-chars in byte-compiled mode only. +(when (compiled-function-p (symbol-function 'test-chars)) + (test-chars t)) (defun unicode-code-point-to-utf-8-string (code-point) "Convert a Unicode code point to the equivalent UTF-8 string. -- ‘As I sat looking up at the Guinness ad, I could never figure out / How your man stayed up on the surfboard after forty pints of stout’ (C. Moore)