Hi Stephen,
Here goes the changelog entry:
----------------------------------------------------------------
2006-01-06 Rodrigo Ventura <yoda(a)isr.ist.utl.pt>
* supercite.el (sc-toggle-var): Fixed the reporting of the result
of the toggle (call to message).
----------------------------------------------------------------
and the patch:
----------------------------------------------------------------
--- supercite.el~ 2005-10-29 19:03:37.000000000 +0100
+++ supercite.el 2006-01-04 14:14:14.000000000 +0000
@@ -1904,10 +1904,11 @@
"Boolean toggle VARIABLE's value.
VARIABLE must be a bound symbol. Nil values change to t, non-nil
values are changed to nil."
- (message "%s changed from %s to %s"
- variable (symbol-value variable)
- (set-variable variable (not (eval-expression variable))))
- (sc-set-mode-string))
+ (let ((new-value (not (eval-expression variable))))
+ (message "%s changed from %s to %s"
+ variable (symbol-value variable) new-value)
+ (set-variable variable new-value)
+ (sc-set-mode-string)))
(defun sc-set-variable (var)
"Set the Supercite VARIABLE.
----------------------------------------------------------------
I tried to change as little as possible. I don't understand, for
instance, why (symbol-value variable) is used in one place, while
(eval-expression variable) is used with apparently the same purpose
above.
Thank you,
Cheers,
Rodrigo
--
*** Rodrigo Martins de Matos Ventura <yoda(a)isr.ist.utl.pt>
*** Web page:
http://www.isr.ist.utl.pt/~yoda
*** Teaching Assistant and PhD Student at ISR:
*** Instituto de Sistemas e Robotica, Polo de Lisboa
*** Instituto Superior Tecnico, Lisboa, PORTUGAL
*** PGP fingerprint = 0119 AD13 9EEE 264A 3F10 31D3 89B3 C6C4 60C6 4585