APPROVE COMMIT packages
Eek! I forgot all about this. Time to do something with it...
On Wed, Jun 26, 2013 at 10:20 PM, Stephen J. Turnbull
How much are these used in those packages? The two predicates might
benefit from being defsubsts, but for that to be useful they'd need to
be dumped, I guess.
All 3 of them are called via the equivalent of funcall, so making them
defsubsts wouldn't help.
I am committing this patch, except that I decided to go with this
version of booleanp instead:
(defun booleanp (object)
"Return t if OBJECT is one of the two canonical boolean values: t or nil.
Otherwise, return nil."
(or (null object) (eq object t)))
The main object is to be clearer. I can glance at this version and
tell what it does in a second. The memq version requires me to think
about it. Also, this version doesn't put a sequence on the heap, AND
doesn't require traversing a sequence. It's just better all around,
except that it is 2 characters longer.
XEmacs-Patches mailing list