Ar an dara lá de mí Aibréan, scríobh Stephen J. Turnbull:
Aidan Kehoe writes:
> Where you’ve rewritten comments, your rewrites are more opaque to me
> than what was there before. But then I wrote what was there before
> (still long enough ago to need to understand it though), so maybe
> that’s not surprising.
I did rewrite the comment about using int, not UExtbyte, for byte1 and
byte2. Someone who knows Mule well would guess UExtbyte, I agree, but
my purpose for the comment is to explain why those *must* be ints,
even though C would normally coerce other, more intuitive, integral
types to whatever is needed. This minimal approach is purely a matter
of style; if you still dislike it I'll correct the misspelling of
UExtbyte and otherwise leave it alone.
I don’t have strong feelings about it, or about the rest of your changes to
the comments, and I have no objection to them going in--it absolutely may be
that more people find your formulation the more readable. I haven’t done any
I suppose I wanted to say that reworking code and comments into what you
perceive as something more readable doesn’t necessarily help the next person
working on them. It might, it might not. Bug fixes and functionality are
normally more important.
On the quay of the little Black Sea port, where the rescued pair came once
more into contact with civilization, Dobrinton was bitten by a dog which was
assumed to be mad, though it may only have been indiscriminating. (Saki)
XEmacs-Patches mailing list