Without these patches, when I build the packages under 21.4, I get build errors like this one: While compiling toplevel forms in file /home/acs/xemacs-packages-2004-12-04/xemacs-packages/prog-modes/tcl.el: !! error (("No such face" font-lock-string-face)) backtrace(nil t) # bind (error-info) byte-compile-report-error((error "No such face" font-lock-string-face)) # bind (error-info) #<compiled-function (error-info) "...(4)" [error-info byte-compile-report-error] 2>((error "No such face" font-lock-string-face)) get-face(font-lock-string-face) # bind (how-to-add tag-set locale parent face) set-face-parent(change-log-date-face font-lock-string-face) byte-code("..." [make-face change-log-date-face "Face used to highlight dates in date lines." set-face-parent font-lock-string-face change-log-name-face "Face for highlighting author names." font-lock-constant-face change-log-email-face "Face for highlighting author email addresses." font-lock-variable-name-face change-log-file-face "Face for highlighting file names." font-lock-function-name-face change-log-list-face "Face for highlighting parenthesized lists of functions or variables." font-lock-keyword-face change-log-conditionals-face "Face for highlighting conditionals of the form `[...]'." change-log-function-face "Face for highlighting items of the form `<....>'." change-log-acknowledgement-face "Face for highlighting acknowledgments." font-lock-comment-face] 3) # bind (current-load-list) # (unwind-protect ...) # bind (load-file-name) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) # (unwind-protect ...) load-internal("add-log" nil t nil nil nil) # bind (nosuffix nomessage noerror file) load("add-log" nil t nil) # (unwind-protect ...) require(add-log) (progn (require (quote imenu)) (require (quote outline)) (require (quote dabbrev)) (require (quote add-log))) eval((progn (require (quote imenu)) (require (quote outline)) (require (quote dabbrev)) (require (quote add-log)))) # bind (sym def G43823) # (unwind-protect ...) # bind (save-macro-environment form) byte-compile-eval((progn (require (quote imenu)) (require (quote outline)) (require (quote dabbrev)) (require (quote add-log)))) (list (quote quote) (byte-compile-eval (cons ... body))) # bind (body) (lambda (&rest body) (list (quote quote) (byte-compile-eval ...)))((require (quote imenu)) (require (quote outline)) (require (quote dabbrev)) (require (quote add-log))) #<subr macroexpand-internal>((eval-when-compile (require (quote imenu)) (require (quote outline)) (require (quote dabbrev)) (require (quote add-log))) ((byte-compiler-options lambda (&rest forms) (apply ... forms)) (eval-when-compile lambda (&rest body) (list ... ...)) (eval-and-compile lambda (&rest body) (byte-compile-eval ...) (cons ... body)))) # bind (cl-macro-environment cl-env cl-macro) macroexpand((eval-when-compile (require (quote imenu)) (require (quote outline)) (require (quote dabbrev)) (require (quote add-log))) ((byte-compiler-options lambda (&rest forms) (apply ... forms)) (eval-when-compile lambda (&rest body) (list ... ...)) (eval-and-compile lambda (&rest body) (byte-compile-eval ...) (cons ... body)))) # bind (byte-compile-current-form handler form) byte-compile-file-form((eval-when-compile (require (quote imenu)) (require (quote outline)) (require (quote dabbrev)) (require (quote add-log)))) # (unwind-protect ...) #<compiled-function nil "...(43)" [byte-compile-unresolved-functions byte-compile-inbuffer 1 " \n " nil looking-at ";" byte-compile-file-form read byte-compile-flush-pending byte-compile-warn-about-unresolved-functions] 3>() # (unwind-protect ...) call-with-condition-handler(#<compiled-function (error-info) "...(4)" [error-info byte-compile-report-error] 2> #<compiled-function nil "...(43)" [byte-compile-unresolved-functions byte-compile-inbuffer 1 " \n " nil looking-at ";" byte-compile-file-form read byte-compile-flush-pending byte-compile-warn-about-unresolved-functions] 3>) # (unwind-protect ...) # bind (byte-compile-warnings-beginning byte-compile-point-max-prev byte-compile-log-buffer byte-compile-macro-environment byte-compile-function-environment byte-compile-autoload-environment byte-compile-unresolved-functions byte-compile-bound-variables byte-compile-free-references byte-compile-free-assignments byte-compile-verbose byte-optimize byte-compile-emacs19-compatibility byte-compile-dynamic byte-compile-dynamic-docstrings byte-compile-warnings byte-compile-file-domain byte-compile-outbuffer float-output-format case-fold-search print-length print-level byte-compile-constants byte-compile-variables byte-compile-tag-number byte-compile-depth byte-compile-maxdepth byte-compile-output eval filename byte-compile-inbuffer) byte-compile-from-buffer(#<buffer " *Compiler Input*"> "/home/acs/xemacs-packages-2004-12-04/xemacs-packages/prog-modes/tcl.el") # bind (byte-compile-current-file target-file input-buffer output-buffer byte-compile-dest-file load filename) byte-compile-file("tcl.el") byte-code("..." [file byte-compile-file t] 2) # (condition-case ... . ((error (byte-code "ÂÃ!!ÂÄ!ÅÆ!«Æ Ç\"ªÂ ＠ÈN® ＠!ÉÊ A\"ÂË!Ç" ... 3)))) # bind (file) batch-byte-compile-1("tcl.el") # bind (error file-to-process) batch-byte-compile-one-file() # bind (error) batch-byte-compile() # bind (arg) command-line-do-funcall("-f") # bind (dir file-count line end-of-options file-p arg tem) command-line-1() # bind (command-line-args-left) command-line() # (condition-case ... . ((t (byte-code " Â" ... 1)))) # bind (error-data) normal-top-level() # (condition-case ... . error) # (catch top-level ...) No such face: font-lock-string-face xemacs-packages/pcl-cvs/ChangeLog addition: 2004-12-04 Vin Shelton <acs(a)xemacs.org&gt; * cvs-edit.el (font-lock): Added required font-lock. xemacs-packages/prog-modes/ChangeLog addition: 2004-12-04 Vin Shelton <acs(a)xemacs.org&gt; * make-mode.el: font-lock now required by add-log. * tcl.el: font-lock now required by add-log. packages source patch: Diff command: cvs -q diff -u Files affected: xemacs-packages/prog-modes/tcl.el xemacs-packages/prog-modes/make-mode.el xemacs-packages/pcl-cvs/cvs-edit.el Index: xemacs-packages/pcl-cvs/cvs-edit.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/pcl-cvs/cvs-edit.el,v retrieving revision 2.2 diff -a -u -u -r2.2 cvs-edit.el --- xemacs-packages/pcl-cvs/cvs-edit.el 2001/07/14 09:08:35 2.2 +++ xemacs-packages/pcl-cvs/cvs-edit.el 2004/12/04 23:36:58 ＠＠ -33,6 +33,7 ＠＠ ;;; Code: (eval-when-compile (require 'cl)) +(require 'font-lock) (require 'add-log) ; for all the ChangeLog goodies (require 'pcl-cvs-util) (require 'ring) Index: xemacs-packages/prog-modes/make-mode.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/prog-modes/make-mode.el,v retrieving revision 1.10 diff -a -u -u -r1.10 make-mode.el --- xemacs-packages/prog-modes/make-mode.el 2003/07/21 07:03:34 1.10 +++ xemacs-packages/prog-modes/make-mode.el 2004/12/04 23:36:59 ＠＠ -97,6 +97,7 ＠＠ (unless (featurep 'xemacs) (require 'imenu)) (require 'dabbrev) + (require 'font-lock) (require 'add-log)) ;; Used to generate some fancy regexps Index: xemacs-packages/prog-modes/tcl.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/prog-modes/tcl.el,v retrieving revision 1.10 diff -a -u -u -r1.10 tcl.el --- xemacs-packages/prog-modes/tcl.el 2003/01/06 18:31:23 1.10 +++ xemacs-packages/prog-modes/tcl.el 2004/12/04 23:37:00 ＠＠ -111,6 +111,7 ＠＠ (require 'imenu) (require 'outline) (require 'dabbrev) + (require 'font-lock) (require 'add-log)) ;; I sure wish Emacs had a package that made it easy to extract this