APPROVE COMMIT 21.5 Vin: a separate, untested, patch follows for 21.4. Julian's analysis is correct, and with his patch the test I added last week passes. Julian's analysis follows the patch. diff -r 38493c0fb952 src/ChangeLog --- a/src/ChangeLog Sun Nov 02 00:12:13 2008 +0900 +++ b/src/ChangeLog Sun Nov 02 00:16:48 2008 +0900 ＠＠ -0,0 +1,5 ＠＠ +2008-11-01 Stephen J. Turnbull <stephen(a)xemacs.org&gt; + + * regex.c (re_search_2): Fix at_dot by changing charpos to bytepos. + From Julian Bradfield <18654.1143.304851.782755(a)krk.inf.ed.ac.uk&gt;. + diff -r 38493c0fb952 src/regex.c --- a/src/regex.c Sun Nov 02 00:12:13 2008 +0900 +++ b/src/regex.c Sun Nov 02 00:16:48 2008 +0900 ＠＠ -4313,8 +4313,8 ＠＠ { if (!BUFFERP (lispobj)) return -1; - range = (BUF_PT (XBUFFER (lispobj)) - BUF_BEGV (XBUFFER (lispobj)) - - startpos); + range = (BYTE_BUF_PT (XBUFFER (lispobj)) + - BYTE_BUF_BEGV (XBUFFER (lispobj)) - startpos); if (range < 0) return -1; } Julian Bradfield writes: _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches