3:58 a.m.
Vin Shelton writes:
Jerry -
On Wed, Mar 6, 2013 at 10:32 AM, Jerry James <james(a)xemacs.org> wrote:
> APPROVE COMMIT 21.5
All my 21.5 builds are failing like this:
See my reply to Thomas. Fixes for me (I get a build that runs,
although I haven't tested it yet), but I'd like Jerry's confirmation
that I got the parity of the #ifdefs right.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
3:08 p.m.
New subject: [AC 21.5] Large file support
On Wed, Mar 6, 2013 at 8:58 PM, Stephen J. Turnbull <stephen(a)xemacs.org> wrote:
See my reply to Thomas. Fixes for me (I get a build that runs,
although I haven't tested it yet), but I'd like Jerry's confirmation
that I got the parity of the #ifdefs right.
You did. I came to the same conclusion and pushed the change last
night (my time).
--
Jerry James
http://www.jamezone.org/
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
3:05 a.m.
New subject: [AC 21.5] Large file support
The Windows native build fails without the below patch. Is it OK to
apply it? Win native, cygwin and my linux builds all seem to work.
Basically, using config.h.in in the Windows build process means that
the #undef needs to be separated from the definition.
Also, it seemed to me that in the old version since
#undef AC_FUNC_FSEEKO
#ifdef AC_FUNC_FSEEKO
were right next to each other, OFF_T was always defined as long, but I
was probably missing something.
- Vin
diff -r f7abcda06b1b src/ChangeLog
--- a/src/ChangeLog Fri Mar 08 13:43:06 2013 -0700
+++ b/src/ChangeLog Mon Mar 11 22:54:43 2013 -0400
＠＠ -1,3 +1,7 ＠＠
+2013-03-11 Vin Shelton <acs(a)xemacs.org>
+
+ * config.h.in: Move large file support outside WIN32_NO_CONFIGURE block.
+
2013-03-07 Jerry James <james(a)xemacs.org>
* array.c (stack_like_malloc): Define only if WIN32_ANY.
diff -r f7abcda06b1b src/config.h.in
--- a/src/config.h.in Fri Mar 08 13:43:06 2013 -0700
+++ b/src/config.h.in Mon Mar 11 22:54:43 2013 -0400
＠＠ -761,15 +761,6 ＠＠
/* Large file support */
#undef AC_FUNC_FSEEKO
-#ifdef AC_FUNC_FSEEKO
-# define OFF_T off_t
-# define FSEEK(stream, offset, whence) fseeko (stream, offset, whence)
-# define FTELL(stream) ftello (stream)
-#else
-# define OFF_T long
-# define FSEEK(stream, offset, whence) fseek (stream, offset, whence)
-# define FTELL(stream) ftell (stream)
-#endif
/* some systems (Cygwin) typedef u?intptr_t in <sys/types.h>
but the standard is <inttypes.h>
＠＠ -1187,4 +1178,15 ＠＠
#define SUPPORT_CONFOUNDING_FUNCTIONS NEED_TO_HANDLE_21_4_CODE
+/* Large file support */
+#ifdef AC_FUNC_FSEEKO
+# define OFF_T off_t
+# define FSEEK(stream, offset, whence) fseeko (stream, offset, whence)
+# define FTELL(stream) ftello (stream)
+#else
+# define OFF_T long
+# define FSEEK(stream, offset, whence) fseek (stream, offset, whence)
+# define FTELL(stream) ftell (stream)
+#endif
+
#endif /* _SRC_CONFIG_H_ */
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
1:54 p.m.
New subject: [AC 21.5] Large file support
APPROVE
On Mon, Mar 11, 2013 at 9:05 PM, Vin Shelton <acs(a)alumni.princeton.edu> wrote:
The Windows native build fails without the below patch. Is it OK to
apply it? Win native, cygwin and my linux builds all seem to work.
Yes, this looks right. Sorry, I don't have access to any Windows
machines to test changes on. My home and work machines, as well as my
laptop, all run Linux.
Basically, using config.h.in in the Windows build process means that
the #undef needs to be separated from the definition.
Also, it seemed to me that in the old version since
#undef AC_FUNC_FSEEKO
#ifdef AC_FUNC_FSEEKO
were right next to each other, OFF_T was always defined as long, but I
was probably missing something.
The configure script changes the #undef into a #define if your
platform has fseeko().
--
Jerry James
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
2:29 p.m.
New subject: [AC 21.5] Large file support
> Also, it seemed to me that in the old version since
>
> #undef AC_FUNC_FSEEKO
> #ifdef AC_FUNC_FSEEKO
>
> were right next to each other, OFF_T was always defined as long, but I
> was probably missing something.
The configure script changes the #undef into a #define if your
platform has fseeko().
Yes, because this file is used as-is in the Windows build process, I
forgot that this fragment lives in config.h.in, so it gets transformed
by autoconf.
I'll apply the patch when I get home tonight.
- Vin
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
4064
days inactive
4069
days old
4 comments
3 participants
participants (3)
-
Jerry James -
Stephen J. Turnbull -
Vin Shelton