"Stephen J. Turnbull" <stephen(a)xemacs.org> wrote:
Sorry to dredge this up 8 months after the commit, but I just realized
what was happening here due to a question on c.e.x. If we decide to
pull this junk, I'll do the work.
Can you give me a pointer to the c.e.x. question? Google groups would
be great since I lost my Usenet feed in August.
>>>>> "Jerry" == Jerry James <james(a)xemacs.org> writes:
Jerry> * frame.el: Synch with Emacs 21.3.
Jerry> -;; FSFmacs has weird functions `set-default-font',
Jerry> -;; `set-foreground-color' here. They don't do sensible things
Jerry> -;; set faces; instead they set frame properties (??!!) and call
Jerry> -;; useless functions such as `frame-update-faces' and
Jerry> -;; `frame-update-face-colors'.
Jerry> +;; XEmacs change: this function differs significantly from Emacs.
Jerry> +(defun set-foreground-color (color-name)
seems really questionable. We did without these functions for at
least five or six years (the deprecation comment is in 21.1), the
names suck very badly, the implementation is completely different,
Before you start pulling them, you'd better look around and see where
they are being used already. For example, set-foreground-color is used
in the ess package; do a grep on display-graphic-p in the packages.
I agree that this stuff is questionable. I put it in purely as an aid
to porting. I wouldn't mind at all moving it to fsf-compat and putting
big warning signs: "THERE BE DRAGONS HERE".