APPROVE COMMIT 21.5
Not for 21.4.
Index: src/ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/ChangeLog,v
retrieving revision 1.944
diff -u -r1.944 ChangeLog
--- src/ChangeLog 18 Apr 2006 17:28:30 -0000 1.944
+++ src/ChangeLog 22 Apr 2006 14:47:11 -0000
@@ -0,0 +1,4 @@
+2006-04-17 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * unicode.c: Improve comment on to/from_unicode table design.
+
Index: src/unicode.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/unicode.c,v
retrieving revision 1.31
diff -u -r1.31 unicode.c
--- src/unicode.c 25 Oct 2005 11:16:29 -0000 1.31
+++ src/unicode.c 22 Apr 2006 14:47:11 -0000
@@ -202,12 +202,11 @@
#ifdef MULE
-/* #### Using ints for to_unicode is OK (as long as they are >= 32 bits).
- However, shouldn't the shorts below be unsigned?
-
- Answer: Doesn't matter because the values being converted to are only
- 96x96. */
+/* Using ints for to_unicode is OK (as long as they are >= 32 bits).
+ In from_unicode, we're converting from Mule characters, which means
+ that the values being converted to are only 96x96, and we can save
+ space by using shorts (signedness doesn't matter). */
static int *to_unicode_blank_1;
static int **to_unicode_blank_2;
--
Graduate School of Systems and Information Engineering University of Tsukuba
http://turnbull.sk.tsukuba.ac.jp/ Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Economics of Information Communication and Computation Systems
Experimental Economics, Microeconomic Theory, Game Theory