Dear Jérôme, Thank you to for the patch. By coincidence I happened to be working on a sync of sh-script.el to the latest Emacs CVS that I'm currently testing, but I don't mind you finishing first. I have one comment after quickly comparing the two efforts: I found that the menu map definitions in sh-mode-map did not work expected (this bug is also in the existing code). Go get the menu bar to work I stripped all references to menu-map out of sh-mode-map and added the following straight after it: --------------------------------------------------------------------------- (easy-menu-define sh-mode-menu sh-mode-map "Menu for sh-script mode" '("Insert" ["While Loop" sh-while t] ["Until Loop" sh-until t] ["Temporary File" sh-tmp-file t] ["Select Statement" sh-select t] ["Repeat Loop" sh-repeat t] ["Options Loop" sh-while-getopts t] ["Indexed Loop" sh-indexed-loop t] ["If Statement" sh-if t] ["For Loop" sh-for t] ["Case Statement" sh-case t])) --------------------------------------------------------------------------- I then added the following to sh-mode: --------------------------------------------------------------------------- (if sh-mode-menu (easy-menu-add sh-mode-menu)); XEmacs --------------------------------------------------------------------------- The rest of the patch seems OK to me. Malcolm -- Malcolm Purvis <malcolmp(a)xemacs.org&gt;