1:22 p.m.
More support for clojure-mode. Will push on Monday if nobody objects.
2014-09-27 Michael Sperber <mike(a)xemacs.org>
* simple-more.el (start-file-process):
* subr-more.el (start-file-process-shell-command): Port from GNU
Emacs.
---
Regards,
Mike
diff --git a/simple-more.el b/simple-more.el
--- a/simple-more.el
+++ b/simple-more.el
＠＠ -130,4 +130,24 ＠＠
(setq rest (cdr rest)))
done))))
+;;;###autoload
+(defun start-file-process (name buffer program &rest program-args)
+ "Start a program in a subprocess. Return the process object for it.
+
+Similar to `start-process', but may invoke a file handler based on
+`default-directory'. See Info node `(elisp)Magic File Names'.
+
+This handler ought to run PROGRAM, perhaps on the local host,
+perhaps on a remote host that corresponds to `default-directory'.
+In the latter case, the local part of `default-directory' becomes
+the working directory of the process.
+
+PROGRAM and PROGRAM-ARGS might be file names. They are not
+objects of file handler invocation. File handlers might not
+support pty association, if PROGRAM is nil."
+ (let ((fh (find-file-name-handler default-directory 'start-file-process)))
+ (if fh (apply fh 'start-file-process name buffer program program-args)
+ (apply 'start-process name buffer program program-args))))
+
+
;;; simple-more.el ends here
diff --git a/subr-more.el b/subr-more.el
--- a/subr-more.el
+++ b/subr-more.el
＠＠ -195,4 +195,14 ＠＠
tail (cdr tail)))
result))
+;;;###autoload
+(defun start-file-process-shell-command (name buffer &rest args)
+ "Start a program in a subprocess. Return the process object for it.
+Similar to `start-process-shell-command', but calls `start-file-process'."
+ (start-file-process
+ name buffer
+ (if (file-remote-p default-directory) "/bin/sh" shell-file-name)
+ (if (file-remote-p default-directory) "-c" shell-command-switch)
+ (mapconcat 'identity args " ")))
+
;;; subr-more.el ends here
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
4:25 p.m.
Michael Sperber writes:
+;;;###autoload
+(defun start-file-process (name buffer program &rest program-args)
+ "Start a program in a subprocess. Return the process object for it.
+
+Similar to `start-process', but may invoke a file handler based on
+`default-directory'. See Info node `(elisp)Magic File Names'.
+
+This handler ought to run PROGRAM, perhaps on the local host,
+perhaps on a remote host that corresponds to `default-directory'.
What is the format of remote host specification?
+In the latter case, the local part of `default-directory'
becomes
+the working directory of the process.
+
+PROGRAM and PROGRAM-ARGS might be file names.
Erm, what else might they be?
+They are not
+objects of file handler invocation. File handlers might not
+support pty association, if PROGRAM is nil."
Do we need that last sentence? If it's rationale for *why* we don't
invoke file handlers, it doesn't belong in the docstring. Maybe in a
comment. If it is needed, I have no clue what it means.
+ (let ((fh (find-file-name-handler default-directory
'start-file-process)))
+ (if fh (apply fh 'start-file-process name buffer program program-args)
+ (apply 'start-process name buffer program program-args))))
+
+
;;; simple-more.el ends here
diff --git a/subr-more.el b/subr-more.el
--- a/subr-more.el
+++ b/subr-more.el
＠＠ -195,4 +195,14 ＠＠
tail (cdr tail)))
result))
+;;;###autoload
+(defun start-file-process-shell-command (name buffer &rest args)
+ "Start a program in a subprocess. Return the process object for it.
+Similar to `start-process-shell-command', but calls `start-file-process'."
+ (start-file-process
+ name buffer
+ (if (file-remote-p default-directory) "/bin/sh" shell-file-name)
+ (if (file-remote-p default-directory) "-c" shell-command-switch)
+ (mapconcat 'identity args " ")))
+
;;; subr-more.el ends here
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
4:51 p.m.
Thanks for the review!
"Stephen J. Turnbull" <turnbull(a)sk.tsukuba.ac.jp> writes:
Michael Sperber writes:
> +;;;###autoload
> +(defun start-file-process (name buffer program &rest program-args)
> + "Start a program in a subprocess. Return the process object for it.
> +
> +Similar to `start-process', but may invoke a file handler based on
> +`default-directory'. See Info node `(elisp)Magic File Names'.
> +
> +This handler ought to run PROGRAM, perhaps on the local host,
> +perhaps on a remote host that corresponds to `default-directory'.
What is the format of remote host specification?
We don't have that yet, as we don't have any file handlers for that yet.
> +In the latter case, the local part of `default-directory'
becomes
> +the working directory of the process.
> +
> +PROGRAM and PROGRAM-ARGS might be file names.
Erm, what else might they be?
Remote-host specifications :-)
> +They are not
> +objects of file handler invocation. File handlers might not
> +support pty association, if PROGRAM is nil."
Do we need that last sentence? If it's rationale for *why* we don't
invoke file handlers, it doesn't belong in the docstring. Maybe in a
comment. If it is needed, I have no clue what it means.
I'll be happy to strike that sentence before pushing.
--
Regards,
Mike
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
8:10 a.m.
New subject: [SA] Port `start-file-process' and `start-file-process-shell-command'
So I just pushed the attached patch, with the commented as per Stephen's
feedback.
2014-09-27 Michael Sperber <mike(a)xemacs.org>
* simple-more.el (start-file-process):
* subr-more.el (start-file-process-shell-command): Port from GNU
Emacs.
--
Regards,
Mike
diff --git a/simple-more.el b/simple-more.el
--- a/simple-more.el
+++ b/simple-more.el
＠＠ -130,4 +130,22 ＠＠
(setq rest (cdr rest)))
done))))
+;;;###autoload
+(defun start-file-process (name buffer program &rest program-args)
+ "Start a program in a subprocess. Return the process object for it.
+
+Similar to `start-process', but may invoke a file handler based on
+`default-directory'. See Info node `(elisp)Magic File Names'.
+
+This handler ought to run PROGRAM, perhaps on the local host,
+perhaps on a remote host that corresponds to `default-directory'.
+In the latter case, the local part of `default-directory' becomes
+the working directory of the process.
+
+PROGRAM and PROGRAM-ARGS might be file names."
+ (let ((fh (find-file-name-handler default-directory 'start-file-process)))
+ (if fh (apply fh 'start-file-process name buffer program program-args)
+ (apply 'start-process name buffer program program-args))))
+
+
;;; simple-more.el ends here
diff --git a/subr-more.el b/subr-more.el
--- a/subr-more.el
+++ b/subr-more.el
＠＠ -195,4 +195,14 ＠＠
tail (cdr tail)))
result))
+;;;###autoload
+(defun start-file-process-shell-command (name buffer &rest args)
+ "Start a program in a subprocess. Return the process object for it.
+Similar to `start-process-shell-command', but calls `start-file-process'."
+ (start-file-process
+ name buffer
+ (if (file-remote-p default-directory) "/bin/sh" shell-file-name)
+ (if (file-remote-p default-directory) "-c" shell-command-switch)
+ (mapconcat 'identity args " ")))
+
;;; subr-more.el ends here
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
3490
days inactive
3493
days old
3 comments
2 participants
participants (2)
-
Michael Sperber -
Stephen J. Turnbull