Hi all, I noticed the latest eshell mode will caused a error when exiting XEmacs (in case there's live eshell buffer). It was cause by a never defined variable 'eshell-save-history-on-exit. Following is the ChangeLog and fix I composed for the issue~~ Could you please help review and commit it to package repository? Thanks, FKtPp ChangeLog addition: 2009-01-25 It's me FKtPp ;) <m_pupil(a)yahoo.com.cn&gt; * em-hist.el (eshell-save-history-on-exit): NEW. default to nil * em-hist.el (eshell-hist-initialize): make 'eshell-save-history-on-exit buffer locale by default. * em-hist.el (eshell-save-some-history): simplify the evaluation logic. eshell[Packages] source patch: Diff command: cvs -q diff -u Files affected: em-hist.el =================================================================== RCS Index: em-hist.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/eshell/em-hist.el,v retrieving revision 1.2 diff -u -r1.2 em-hist.el --- em-hist.el 2008/08/27 21:26:31 1.2 +++ em-hist.el 2009/01/25 11:34:54 ＠＠ -187,6 +187,7 ＠＠ (defvar eshell-history-index nil) (defvar eshell-matching-input-from-input-string "") (defvar eshell-save-history-index nil) +(defvar eshell-save-history-on-exit nil) (defvar eshell-isearch-map nil) ＠＠ -270,9 +271,10 ＠＠ (make-local-variable 'eshell-history-index) (make-local-variable 'eshell-save-history-index) + (make-local-variable 'eshell-save-history-on-exit) (if (minibuffer-window-active-p (selected-window)) - (set (make-local-variable 'eshell-save-history-on-exit) nil) + (setq eshell-save-history-on-exit nil) (set (make-local-variable 'eshell-history-ring) nil) (if eshell-history-file-name (eshell-read-history nil t)) ＠＠ -299,8 +301,7 ＠＠ (with-current-buffer buf (if (and eshell-mode eshell-history-file-name - eshell-save-history-on-exit - (or (eq eshell-save-history-on-exit t) + (or eshell-save-history-on-exit (y-or-n-p (format "Save input history for Eshell buffer `%s'? " (buffer-name buf))))) _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches