APPROVE COMMIT 21.5 This fixes a minor error in one comment, and adds some comments on side effects that were very unobvious to me when I had to track them down. diff -r 2669b1b7e33b -r 871eb054b34a src/ChangeLog --- a/src/ChangeLog Sat Jan 31 13:06:37 2009 +0000 +++ b/src/ChangeLog Tue Nov 25 10:44:16 2008 +0900 ＠＠ -137,6 +137,17 ＠＠ * input-method-xlib.c: Use Xt_RESOURCE. +2008-11-25 Stephen J. Turnbull <stephen(a)xemacs.org&gt; + + * elhash.c (hash_table_data_validate): + * elhash.c (decode_hash_table_rehash_size): + * elhash.c (decode_hash_table_rehash_threshold): + Document side effects used in these functions. + +2008-11-20 Stephen J. Turnbull <stephen(a)xemacs.org&gt; + + * console-x-impl.h (struct x_frame): Clarify comment. + 2008-11-01 Stephen J. Turnbull <stephen(a)xemacs.org&gt; * regex.c (re_search_2): Fix at_dot by changing charpos to bytepos. diff -r 2669b1b7e33b -r 871eb054b34a src/console-x-impl.h --- a/src/console-x-impl.h Sat Jan 31 13:06:37 2009 +0000 +++ b/src/console-x-impl.h Tue Nov 25 10:44:16 2008 +0900 ＠＠ -332,7 +332,7 ＠＠ or partially hidden by another X window */ unsigned int totally_visible_p :1; - /* NB: Both of the following flags are derivable from the 'shell' + /* NB: Both of the following flags are derivable from the 'widget' field above, but it's easier if we also have them separately here. */ /* Are we a top-level frame? This means that our shell is a diff -r 2669b1b7e33b -r 871eb054b34a src/elhash.c --- a/src/elhash.c Sat Jan 31 13:06:37 2009 +0000 +++ b/src/elhash.c Tue Nov 25 10:44:16 2008 +0900 ＠＠ -755,6 +755,7 ＠＠ static double decode_hash_table_rehash_size (Lisp_Object rehash_size) { + /* -1.0 signals make_general_lisp_hash_table to use the default. */ return NILP (rehash_size) ? -1.0 : XFLOAT_DATA (rehash_size); } ＠＠ -786,6 +787,7 ＠＠ static double decode_hash_table_rehash_threshold (Lisp_Object rehash_threshold) { + /* -1.0 signals make_general_lisp_hash_table to use the default. */ return NILP (rehash_threshold) ? -1.0 : XFLOAT_DATA (rehash_threshold); } ＠＠ -795,6 +797,7 ＠＠ { int len; + /* Check for improper lists while getting length. */ GET_EXTERNAL_LIST_LENGTH (value, len); if (len & 1) ＠＠ -804,6 +807,7 ＠＠ value, Qhash_table, errb); return 0; } + return 1; } _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches