OK, I looked at this, and this code change is exactly right.
Please make it clear in the ChangeLog that this change is specifically
to fix breakage in the stricter perl 5.10.
Martin
>>>> "M" == Michael Sperber
<sperber(a)deinprogramm.de> writes:
M> Thanks for looking at this!
M> Martin Buchholz <martin(a)xemacs.org> writes:
>>
>>>> "M" == Michael
Sperber <sperber(a)deinprogramm.de> writes:
>
M> These are things I needed to do to get the build to succeed. I'll
M> commit on Saturday or so if nobody objects.
>
M> DISCLAIMER: I'm a Windows and ESPECIALLY PERL
dummy. Review appreciated.
>
>
M> src/ChangeLog:
>
M> 2008-01-24 Mike Sperber <mike(a)xemacs.org>
>
M> * make-src-depend (PrintDeps): Fix Perl error.
>
M> diff --git a/src/make-src-depend
b/src/make-src-depend
M> --- a/src/make-src-depend
M> +++ b/src/make-src-depend
M> @@ -115,7 +115,7 @@ sub PrintDeps {
M> my $file = shift;
M> my $ofile = $file; $ofile =~ s/c$/o/; print "$ofile: ";
M> if (exists $uses{$file}{'lisp.h'}) {
M> - delete @{%{$uses{$file}}}{@LISP_H};
M> + delete $uses{$file}{@LISP_H};
M> $uses{$file}{'$(LISP_H)'} = 1;
M> }
M> # Note: If both config.h and lisp.h are dependencies, config.h got deleted
>
>> That perl code (which I believe I wrote) has
worked well for a decade.
>> I'm curious what problem you are trying to address now.
>> (Yes, perl sigils are terminally confusing)
M> Perl 5.10 gives me:
M> Can't use string as a HASH ref while "strict refs"
M> ... on this line.
M> --
M> Cheers =8-} Mike
M> Friede, Völkerverständigung und überhaupt blabla
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches