changeset: 4368:1740095ec116f9e1cbd7db413b98c22e3a56f862 tag: tip parent: 4367:69e6352406f0393738f99a6d250c351e7016f47b parent: 4366:7b628daa39d4f27558b6b0f1a43e692cc7062a15 user: Aidan Kehoe <kehoea(a)parhasard.net&gt; date: Sun Dec 30 15:34:02 2007 +0100 files: description: Automated merge with file:/Sources/xemacs-21.5-checked-out diff -r 69e6352406f0393738f99a6d250c351e7016f47b -r 1740095ec116f9e1cbd7db413b98c22e3a56f862 tests/ChangeLog --- a/tests/ChangeLog Sun Dec 30 15:33:13 2007 +0100 +++ b/tests/ChangeLog Sun Dec 30 15:34:02 2007 +0100 ＠＠ -1,3 +1,11 ＠＠ 2007-12-21 Stephen J. Turnbull <stephe +2007-12-29 Stephen J. Turnbull <stephen(a)xemacs.org&gt; + + * automated/test-harness.el (test-harness-test-compiled): + Improve docstring. + + * automated/weak-tests.el (test-harness-test-compiled): + Remove debugging code. + 2007-12-21 Stephen J. Turnbull <stephen(a)xemacs.org&gt; * reproduce-crashes.el: Renamed from reproduce-bugs.el. Update to-do. diff -r 69e6352406f0393738f99a6d250c351e7016f47b -r 1740095ec116f9e1cbd7db413b98c22e3a56f862 tests/automated/test-harness.el --- a/tests/automated/test-harness.el Sun Dec 30 15:33:13 2007 +0100 +++ b/tests/automated/test-harness.el Sun Dec 30 15:34:02 2007 +0100 ＠＠ -71,7 +71,17 ＠＠ on the system, or a system error might o (defvar unexpected-test-file-failures) (defvar test-harness-test-compiled nil - "Non-nil means the test code was compiled before execution.") + "Non-nil means the test code was compiled before execution. + +You probably should not make tests depend on compilation. +However, it can be useful to conditionally change messages based on whether +the code was compiled or not. For example, the case that motivated the +implementation of this variable: + +\(when test-harness-test-compiled + ;; this ha-a-ack depends on the failing compiled test coming last + \(setq test-harness-failure-tag + \"KNOWN BUG - fix reverted; after 2003-10-31 notify stephen\n\"))") (defvar test-harness-verbose (and (not noninteractive) (> (device-baud-rate) search-slow-speed)) diff -r 69e6352406f0393738f99a6d250c351e7016f47b -r 1740095ec116f9e1cbd7db413b98c22e3a56f862 tests/automated/weak-tests.el --- a/tests/automated/weak-tests.el Sun Dec 30 15:33:13 2007 +0100 +++ b/tests/automated/weak-tests.el Sun Dec 30 15:34:02 2007 +0100 ＠＠ -35,11 +35,6 ＠＠ (when (and (boundp 'load-file-name) (stringp load-file-name)) (push (file-name-directory load-file-name) load-path) (require 'test-harness)))) - -(when test-harness-test-compiled - ;; this ha-a-ack depends on the compiled test coming last - (setq test-harness-failure-tag - "KNOWN BUG - fix reverted; after 2003-10-31 bitch at stephen\n")) (garbage-collect) _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches