APPROVE COMMIT NOTE: This patch has been committed # HG changeset patch # User Aidan Kehoe <kehoea(a)parhasard.net&gt; # Date 1530475616 -3600 # Sun Jul 01 21:06:56 2018 +0100 # Node ID 7fb73e4efef3a3629eaf1b4253d47751e65894fa # Parent c27d849506b0836a8c8b9052dbb178048229da2a Remove an unnecessary warning from fontconfig.el by fixing the byte compiler lisp/ChangeLog addition: 2018-07-01 Aidan Kehoe <kehoea(a)parhasard.net&gt; * bytecomp.el (byte-compile-normal-call): When examining the :test, :key, etc arguments, be aware that a quoted symbol may be a data placeholder, and take that into account before warning. [...] diff -r c27d849506b0 -r 7fb73e4efef3 lisp/ChangeLog --- a/lisp/ChangeLog Sun Jul 01 16:32:48 2018 +0100 +++ b/lisp/ChangeLog Sun Jul 01 21:06:56 2018 +0100 ＠＠ -1,5 +1,9 ＠＠ 2018-07-01 Aidan Kehoe <kehoea(a)parhasard.net&gt; + * bytecomp.el (byte-compile-normal-call): + When examining the :test, :key, etc arguments, be aware that a + quoted symbol may be a data placeholder, and take that into + account before warning. * cl-extra.el (cl-macroexpand-all): Only close around variables that are actually *used* in the lambda, when dealing with lambdas and lexical scope. diff -r c27d849506b0 -r 7fb73e4efef3 lisp/bytecomp.el --- a/lisp/bytecomp.el Sun Jul 01 16:32:48 2018 +0100 +++ b/lisp/bytecomp.el Sun Jul 01 21:06:56 2018 +0100 ＠＠ -3165,11 +3165,29 ＠＠ (map nil (function* (lambda ((function . nargs)) - (let ((value (plist-get plist function not-present))) + (let ((value (plist-get plist function not-present)) + list) (when (and (not (eq value not-present)) (byte-compile-constp value)) + (setq value (eval value)) + (when (and (symbolp value) + (get value + 'byte-compile-label-calls) + (not (assq + value + byte-compile-function-environment))) + (setq list byte-compile-function-environment) + (while list + (when (and + (symbolp (caar list)) + (eq value + (get (caar list) + 'byte-compile-data-placeholder))) + (setq value (caar list) + list nil)) + (setq list (cdr list)))) (byte-compile-callargs-warn - (cons (eval value) + (cons value (member* nargs ;; Dummy arguments. There's no need for -- ‘As I sat looking up at the Guinness ad, I could never figure out / How your man stayed up on the surfboard after forty pints of stout’ (C. Moore)