QUERY Ville> 21.5 RECOMMEND 21.4 Ville> Here's some trivialish GNU Emacs CVS syncs for simple.el Ville> that I've come across in the new vc package. Will commit Ville> in a couple of days unless there are objections. Vin, the Ville> patch applies to 21.4 with some line offsets, so if you Ville> think these are innocent enough for the stable branch, I Ville> have no objections to applying these there as well. The additional optional argument for `goto-line' is a good idea. Commit that any time, as far as I'm concerned. I object to the removal of the comment about "unwanted side effect" in the documentation string of `next-line-add-newlines'. When it's non-nil `(while t (next-line 1))' can crash your XEmacs, and possibly your system, with an out-of-memory error. It will corrupt your file if used in a macro with a large repeat count. Etc. Do change "FSF" to "GNU" if the statement about their default is correct, and I don't care that much about the Steve Baur comment, it was old when I joined the project :-). I'm also not terribly happy about the sync of `next-line' and `previous-line'. Those syntax errors are a pretty reliable indicator of buggy code in my experience. I've run into these errors several times, and each time converting to `forward-line' was simple, and either fixed bugs or made correctness obvious where it was not with `next-line'. Non-nil `next-line-add-newlines' was always a potential problem, and when moving to the goal column was useful, you need careful analysis to be sure the `next-line' behavior is correct for you. Please check whether converting vc to use `forward-line' is better idea. -- School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.

SUPERSEDES 21.5 (Splitting replies into two due to half of the patch being committed, this is the yet unapplied one.) On Mon, 2006-04-24 at 16:24 +0900, Stephen J. Turnbull wrote: Will do soon. In the meantime, attached is the not yet applied part of my previous patch for reference.