Looks good to me.
On Tue, 2011-05-03 at 01:58 +0900, Stephen J. Turnbull wrote:
APPROVE COMMIT 21.5
Recommended by Hans de Graaff of Gentoo and reviewed by Marcus
Crestani. Hans, Marcus, please check that I've done the right thing
here. I'll close issue 354 after confirmation, or Marcus can do it
since it's assigned to him.
Marcus, thanks for the review, and thanks to Aidan and Hans for the
diff -r 70af4098e14f src/ChangeLog
--- a/src/ChangeLog Mon May 02 10:51:26 2011 +0100
+++ b/src/ChangeLog Tue May 03 01:42:33 2011 +0900
＠＠ -1,3 +1,8 ＠＠
+2011-05-03 Stephen J. Turnbull <stephen(a)xemacs.org>
+ * dumper.c (pdump_file_try): Remove static qualifier.
+ Thanks to Hans de Graaff of Gentoo and Marcus Crestani.
2011-05-01 Aidan Kehoe <kehoea(a)parhasard.net>
* lread.c (parse_integer):
diff -r 70af4098e14f src/dumper.c
--- a/src/dumper.c Mon May 02 10:51:26 2011 +0100
+++ b/src/dumper.c Tue May 03 01:42:33 2011 +0900
＠＠ -2593,8 +2593,9 ＠＠
#endif /* !WIN32_NATIVE */
+/* This used to be static, but there seems to be a bug in the GCC 4.1.2
+ optimizer that clobbers exe_path. */
pdump_file_try (Wexttext *exe_path)
Wexttext *w = exe_path + wext_strlen (exe_path);
XEmacs-Patches mailing list