Mats Lidell writes:
>>>>> Stephen wrote:
Stephen> I think the rest of the patch is OK but it would be
Stephen> preferable to split the patch into the part that fixes the
Stephen> typo, and a second patch that changes the default.
I'll try that although I don't know the best workflow for that with
mercurial. The new patches I have prepared was done in sequence in
the same workspace.
Don't worry about it. Stefan Monier's diff-mode is useful for this
kind of thing if you want to do it. But otherwise, just remember that
cosmetic and trivial bugfixing patches shouldn't get mixed with
behavior changing patches because the latter might get vetoed, and the
bugfix forgotten.
Stephen> It's also not clear that it works as documented. As
far as I
Stephen> can see this will change the default for "./configure" to be
Stephen> equivalent to "./configure
Stephen> --with-xft=emacs,notabs,nomenus,nogauges". Have you tested
Stephen> that?
Yes. The important detail is that noemacs is set in the else part if
with-xft isn't specified.
Sounds good. Go ahead and commit it. Remember that even if your
commit is bad for some reason, the 'xemacs-beta' repo lags by only a
few days so people always have a very fresh alternative.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches