APPROVE COMMIT packages
Ville Skyttä <scop(a)xemacs.org> wrote:
Hm, I'm pretty sure that at least some versions of XEmacs,
autoloading
derived modes that way doesn't work as expected. There are a number of
examples in the packages tree having workarounds for it by using a dummy
autoload instead; grep for "dummy" eg. in diff-mode.el or php-mode.el.
You're right. I'll add "fix autoloading for derived modes" to my list
of things to do before I die. But for now, I'll add the dummy autoload
you suggested, which should also fix the problem Vin reported. Keep
those reports coming. I've still got 24 hours to fix 'em!
I have committed the following patch.
xemacs-packages/xemacs-base/ChangeLog addition:
2006-05-31 Jerry James <james(a)xemacs.org>
* comint.el: Fix derived-mode autoload as suggested by Ville.
packages source patch:
Diff command: cvs -q diff -uN
Files affected: xemacs-packages/xemacs-base/comint.el
Index: xemacs-packages/xemacs-base/comint.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/xemacs-base/comint.el,v
retrieving revision 1.15
diff -d -u -r1.15 comint.el
--- xemacs-packages/xemacs-base/comint.el 2006/05/29 21:47:01 1.15
+++ xemacs-packages/xemacs-base/comint.el 2006/06/01 03:22:52
@@ -568,7 +568,8 @@
["Send EOF" comint-send-eof t]
))
-;;;###autoload
+;; XEmacs hack: autoload a dummy autoload instead of a derived mode
+;;;###autoload(autoload 'comint-mode "comint" nil t)
(define-derived-mode comint-mode fundamental-mode "Comint"
"Major mode for interacting with an inferior interpreter.
Interpreter name is same as buffer name, sans the asterisks.
--
Jerry James, Assistant Professor james(a)xemacs.org
Computer Science Department
http://www.cs.usu.edu/~jerry/
Utah State University