[COMMIT] Print char table values correctly.
APPROVE COMMIT
NOTE: this patch has been committed.
With another commit after it to fix the bug in the tests, whoops. 21.4 uses
different, correct, code to print char table values.
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1232282993 0
# Node ID 1d11ecca9cd06c9151cb69e55ccc2ebbd998d9b7
# Parent 774e5c7522bf0681f0ecf0ab015d9ec8dcb35486
Print char table values correctly.
src/ChangeLog addition:
2009-01-16 Aidan Kehoe <kehoea(a)parhasard.net>
* chartab.c (print_table_entry):
Print char table values correctly, eliminating some confusion
between symbols and strings.
tests/ChangeLog addition:
2009-01-18 Aidan Kehoe <kehoea(a)parhasard.net>
* automated/lisp-tests.el:
Check that a bug I fixed in char table printing is really gone.
diff -r 774e5c7522bf -r 1d11ecca9cd0 src/ChangeLog
--- a/src/ChangeLog Tue Jan 13 12:07:27 2009 +0000
+++ b/src/ChangeLog Sun Jan 18 12:49:53 2009 +0000
＠＠ -1,3 +1,9 ＠＠
+2009-01-16 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * chartab.c (print_table_entry):
+ Print char table values correctly, eliminating some confusion
+ between symbols and strings.
+
2008-12-30 Aidan Kehoe <kehoea(a)parhasard.net>
* device-x.c (Fx_get_font_path):
diff -r 774e5c7522bf -r 1d11ecca9cd0 src/chartab.c
--- a/src/chartab.c Tue Jan 13 12:07:27 2009 +0000
+++ b/src/chartab.c Sun Jan 18 12:49:53 2009 +0000
＠＠ -317,7 +317,7 ＠＠
a->first = 0;
lisprange = encode_char_table_range (range);
GCPRO1 (lisprange);
- write_fmt_string_lisp (a->printcharfun, "%s %s", 2, lisprange, val);
+ write_fmt_string_lisp (a->printcharfun, "%s %S", 2, lisprange, val);
UNGCPRO;
return 0;
}
diff -r 774e5c7522bf -r 1d11ecca9cd0 tests/ChangeLog
--- a/tests/ChangeLog Tue Jan 13 12:07:27 2009 +0000
+++ b/tests/ChangeLog Sun Jan 18 12:49:53 2009 +0000
＠＠ -1,3 +1,8 ＠＠
+2009-01-18 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * automated/lisp-tests.el:
+ Check that a bug I fixed in char table printing is really gone.
+
2009-01-11 Aidan Kehoe <kehoea(a)parhasard.net>
* automated/lisp-tests.el ():
diff -r 774e5c7522bf -r 1d11ecca9cd0 tests/automated/lisp-tests.el
--- a/tests/automated/lisp-tests.el Tue Jan 13 12:07:27 2009 +0000
+++ b/tests/automated/lisp-tests.el Sun Jan 18 12:49:53 2009 +0000
＠＠ -1327,3 +1327,9 ＠＠
printed-with-uninterned)))
(Assert (null (string-match awkward-regexp printed-with-uninterned
(1+ first-match-start)))))
+
+(let ((char-table-with-string #s(char-table data (?\x00 "text")))
+ (char-table-with-symbol #s(char-table data (?\x00 text))))
+ (Assert (not (string-equal char-table-with-string char-table-with-symbol))
+ "Check that char table elements are quoted correctly when
printing"))
+
--
¿Dónde estará ahora mi sobrino Yoghurtu Nghe, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches