Re: [PATCH 21.5] Don't lose bits in make_fixnum / make_char_1
Ar an t-ochtú lá is fiche de mí na Nollaig, scríobh Jerry James:
PATCH 21.5
This patch (attached to avoid gmail corruption) solves the problem
reported here:
http://list-archive.xemacs.org/pipermail/xemacs-beta/2011-August/021780.html
Briefly, when using lisp-disunion.h, it is possible to lose bits when
shifting, so we need to make sure the value to be shifted has enough
bits. I'm not sure the make_char_1 part is really necessary, but it
doesn't hurt anything and may prevent a problem. The lisp-union.h
definitions do not have this problem, since there is no explicit
shifting.
This seems perfectly reasonable, and given that this behaviour is the same
as the union build has always given, we have some assurance it doesn’t
introduce any new bugs.
--
‘Iodine deficiency was endemic in parts of the UK until, through what has been
described as “an unplanned and accidental public health triumph”, iodine was
added to cattle feed to improve milk production in the 1930s.’
(EN Pearce, Lancet, June 2011)
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches