Re: [R21.4] Improve geometry debugging messages

RECOMMEND 21.4 vin> Can you please generate a 21.4 version of this patch? I vin> would be most grateful. Sure. Index: src/ChangeLog =================================================================== RCS file: /pack/xemacscvs/XEmacs/xemacs/src/ChangeLog,v retrieving revision 1.290.2.109 diff -u -U0 -r1.290.2.109 ChangeLog --- src/ChangeLog 31 Mar 2006 01:28:57 -0000 1.290.2.109 +++ src/ChangeLog 15 May 2006 04:56:45 -0000 ＠＠ -0,0 +1,6 ＠＠ +2006-05-08 Stephen J. Turnbull <stephen(a)xemacs.org&gt; + + * EmacsShell-sub.c (RootGeometryManager): + Change garbage to useful messages under DEBUG_GEOMETRY_MANAGEMENT. + Based on a suggestion by Francois L'Archeveque. + Index: src/EmacsShell-sub.c =================================================================== RCS file: /pack/xemacscvs/XEmacs/xemacs/src/EmacsShell-sub.c,v retrieving revision 1.5.2.2 diff -u -r1.5.2.2 EmacsShell-sub.c --- src/EmacsShell-sub.c 31 Jan 2005 02:55:01 -0000 1.5.2.2 +++ src/EmacsShell-sub.c 15 May 2006 04:56:54 -0000 ＠＠ -335,11 +335,16 ＠＠ result == XtGeometryAlmost ? "XtGeometryAlmost" : "XtGeometryDone"); if (reply->request_mode & CWWidth) - printf ("width returned;"); + printf ("width returned was %d%s", + reply->width, + reply->request_mode & CWHeight ? "; " : ".\n"); if (reply->request_mode & CWHeight) - printf ("height returned;"); - printf ("\n"); - printf (" resulting shell size: %d %d\n", reply->width, reply->height); + printf ("height returned was %d.\n", reply->height); + /* #### does this also need to depend on the result? + With XtGeometryYes there doesn't seem to be a useful reply object. */ + printf (" resulting shell size: %d %d\n", + reply->request_mode & CWWidth ? reply->width : w->core.width, + reply->request_mode & CWHeight ? reply->height : w->core.height); printf ("----------\n"); fflush (stdout); #endif -- School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.