Re: commit: Correct case-insensitive search for non-case, non-ASCII chars. Add tests.
Aidan,
Thanks for cleaning this up.
On Jan 30, 2008 3:27 AM, Aidan Kehoe <aidan-guest(a)alioth.debian.org> wrote:
changeset: 4414:df576f30c1d86395a584eef1558bb945483af1ab
tag: tip
user: Aidan Kehoe <kehoea(a)parhasard.net>
date: Wed Jan 30 09:26:59 2008 +0100
files: src/ChangeLog src/search.c tests/ChangeLog tests/automated/case-tests.el
description:
Correct case-insensitive search for non-case, non-ASCII chars. Add tests.
2008-01-30 Aidan Kehoe <kehoea(a)parhasard.net>
* automated/case-tests.el:
Check for a bug Mike Sperber reported; check algorithms used, if
available.
2008-01-30 Aidan Kehoe <kehoea(a)parhasard.net>
* search.c (debug-xemacs-searches):
New variable, available on debug builds. Used in
tests/automated/case-tests.el.
(search_buffer): Only store the charset_base for characters with
translations. Correct some comments, correct some checks. If
debug_xemacs_searches is non-zero, record which search was used.
(boyer_moore): Remove an assertion that was incorrect. Remove its
documentation. Correct an assertion dealing with equivalence
tables; we may end up looking through the equivalence table if a
non-ASCII non-case character was searched for.
For non-debug builds, I think there's still a minor problem with
search-algorithm-used, however. Here are the test differences between
tests run against 2008-01-28 sources and today's sources:
--- xemacs-21.5-2008-01-28/check.out
+++ xemacs-21.5-2008-01-30/check.out
＠＠ -60 +60,7 ＠＠
-case-tests.el: 1118 of 1118 tests successful (100%).
+FAIL: (eq (quote boyer-moore) search-algorithm-used) ==> error:
(void-variable search-algorithm-used)
+FAIL: (eq (quote boyer-moore) search-algorithm-used) ==> error:
(void-variable search-algorithm-used)
+case-tests.el: 1120 of 1122 tests successful ( 99%).
+ 2 tests skipped because not a DEBUG_XEMACS build.
+ Probably XEmacs cannot find your installed packages. Set EMACSPACKAGEPATH
+ to the package hierarchy root or configure with --package-path to enable
+ the skipped tests.
＠＠ -64,0 +71,2 ＠＠
+FAIL: (eq (quote boyer-moore) search-algorithm-used) ==> error:
(void-variable search-algorithm-used)
+SKIP: nil BECAUSE "not a DEBUG_XEMACS build"
＠＠ -67,0 +76,2 ＠＠
+FAIL: (eq (quote boyer-moore) search-algorithm-used) ==> error:
(void-variable search-algorithm-used)
+SKIP: nil BECAUSE "not a DEBUG_XEMACS build"
＠＠ -70 +80 ＠＠
- 1118 passes
+ 1120 passes
＠＠ -75 +85 ＠＠
- 0 other failures
+ 2 other failures
＠＠ -382 +392 ＠＠
-case-tests.el: 1118 of 1118 tests successful (100%).
+case-tests.el: 1120 of 1122 tests successful ( 99%).
I think the failures should not be there, right?
- Vin
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches