Re: [PATCH] (Draft2) Make X11 server-side fonts and Mule suck less.
Ar an dara lá de mí na Samhain, scríobh stephen(a)xemacs.org:
> No, GNU use fontsets and their Mule charsets have no registry
> property.
*X* Font Sets? eeeeeeeeewwwwwww! Tell me it ain't so!
It’s more or less so--I don’t know enough about X Font Sets to be able to
say if their implementation is compatible. But the idea is similar, and more
depressingly, they use it on Windows, and on Mac OS.
> My first inclination was to throw out the old way entirely,
since it
> involves much use of our under-performing regex engine at redisplay,
And you think much round-tripping to the server is a better idea in
the midst of redisplay? ;-)
There’s less round-tripping in this implementation than in the previous one.
Previously, matches would be tried against the XListFonts results with wildly
inappropriate (to this Mule charset) things in the X11 charset registry;
now, the registry is modified before calling XListFonts, so we never move
through a list of fallbacks that can never have a successful regex match
for the Mule charset in question.
Neither is acceptable. If regex is actually being called from
redisplay,
we should fix that.
I agree :-) .
> > > * console-impl.h:
> > > * console-impl.h (struct console_methods):
> > > Rename the last parameter to a couple of methods; reformat
> > > their declarations.
> >
> > The above will cause some annoyance to CHISE, Carbon XEmacs, and
> > possibly SXEmacs someday. Is it a good idea?
>
> Yes; it moves the last parameter to being an enum with descriptive
> possible values, rather than just an integer.
Well, yes, but is it such a good idea that we should make work for
others? That's one of my pet peeves with GNU.
IMO incorporating that change would make their code base more understandable
and would be a positive change, just as it would be in ours. I don’t think
providing a prompt to do useful work is specious or thoughtless.
--
Santa Maradona, priez pour moi!
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches