Re: [PATCH] Sync sh-script.el with GNU Emacs 21.4

Here are some things I noticed.

The change from > -(defcustom sh-mode-hook nil > - "*Hook run by `sh-mode'." > -:type 'hook > -:group 'sh) > > -(defcustom sh-set-shell-hook nil > - "*Hook run by `sh-set-shell'." > -:type 'hook > -:group 'sh) to the following block changes the customization group from 'sh to 'sh-script. > +(defcustom sh-set-shell-hook nil > + "*Hook run by `sh-set-shell'." > +:type 'hook > +:group 'sh-script) > + > +(defcustom sh-mode-hook nil > + "*Hook run by `sh-mode'." > +:type 'hook > +:group 'sh-script) Is this incompatible change acceptable?

The removal of XEmacs comments (the usual convention is ;; XEmacs change: ... ) is normally not OK, since it's a marker for things to watch out for. > (defcustom sh-alias-alist > - ;; XEmacs: Linux is spelled `linux' > (nconc (if (eq system-type 'linux) > '((csh . tcsh) > (ksh . pdksh))) In this case I can't see anything wrong with this removal, though.

The following is such a loss of an XEmacs-specific change: This should have been marked ;; XEmacs change: ... and not ;; GDF which is the acronym of a nowadays mostly inactive developer. I ran out of energy here and the rest of your patch is not reviewed. <2507 lines deleted by Adrian Aichner> > ＠＠ -1578,14 +3554,11 ＠＠ > (point))) > (newline)))) > > - > - > (defun sh-beginning-of-command () > "Move point to successive beginnings of commands." > (interactive) > (if (re-search-backward sh-beginning-of-command nil t) > (goto-char (match-beginning 2)))) > - > > (defun sh-end-of-command () > "Move point to successive ends of commands." > > Above citation is the end of your mail. It would be a good idea to use a signature or other indication for the end of your mail. Lost data is not unheard off, and I have no way of knowing whether this was really the end of your mail.

Thanks again for your contribution, perhaps you could have a look at the issues I brought up.