Re: [PATCH] issue 757, return system metrics num-color-cells for tty
On Wed, Mar 23, 2011 at 09:17:52AM -0400, Jeff Sparkes wrote:
I'm wondering about the use of log2 in the patch.
1. Is it always available? Configure doesn't check for it.
2. I don't do any casting to int. This works for gcc; is it okay for other
compilers?
log2 manpage says
CONFORMING TO
C99, POSIX.1-2001. The variant returning double also conforms to SVr4,
4.3BSD, C89.
so looks like it has been around for a while. The alternative is using log(x)/log(2)
which is probably what it does internaly anyway on most systems.
Richard
---
Name and OpenPGP keys available from pgp key servers
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches