RECOMMEND 21.4
lisp.h, which is included by unexelf.c, ensures that uintptr_t is
correctly defined.
>>>> "Andrey" == Andrey Slusar
<anrays(a)gmail.com> writes:
SY> Vin, looks to me like this is needed in 21.4 too.
> Uh, just how many ELF platforms has this been tested on? One?
Andrey> No, it's tested on the i386, amd64, ia64, sparc64
Andrey> FreeBSD.
But for you as a FreeBSD developer, that's just another way of saying
"it works for me."
It's more general than a lot of patches we see, but still, it amounts
to a single platform because the most likely problem here will be if
some other OS either doesn't define that type, or defines it in a
non-standard header. So you could test on 100 CPUs and it still would
not tell us about, say, SCO Unix (which I know was still building as
of last year).
It turns out that the issue is moot because unexelf.c #includes
lisp.h, which goes through the necessary gymnastics to ensure that the
uintptr_t type is properly defined. Please try to include that kind
of information in the future. It would save us some time, which is
always nice. From your point of view, it would make it far more
likely that your patches would go through on your reputation alone in
the future, in cases where it's not so easy to prove that it's right.
--
School of Systems and Information Engineering
http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.