COMMIT APPROVE
Always living life on the edge, I've decided to commit this patch for
21.4.20. Thanks, Stephen.
- Vin
"Stephen J. Turnbull" <stephen(a)xemacs.org> writes:
21.4 SXEmacs
Untested on those trees, so I can't quite RECOMMEND it.
This patch implements both of my recent patches to XEmacs 21.5's test
suite in <871wte8y3i.fsf(a)tleepslib.sk.tsukuba.ac.jp> and
<87wtb67hm2.fsf(a)tleepslib.sk.tsukuba.ac.jp> for XEmacs 21.4 (current
CVS) and SXEmacs sxemacs--main--22.1.6 (sorry about the ancient
version, I tried to update but tla timed out, don't know why yet).
Path should apply to either tree with no offsets and no fuzz.
Basically the patch provides two improvements. The first is that
"unexpected errors" are tracked and reported at the end. The second
is that a new test suite API, Silence-Message, is provided to wrap
functions that might call `message' and clutter up the test suite
output with irrelevant remarks about setting the mark or writing
files.
The main difference from the 21.5 patch set is that neither 21.4 nor
SXEmacs has the region-tests.el test file, so that file got dropped.
AFAIK it's relevant to both, but Adrian Aichner would be the one to
ask. If so, I suppose you can simply copy the 21.5 CVS HEAD version,
which will get you both the tests and my noise-suppression patch.
A minor difference is that the mule-tests.el portion of the patch is
less invasive than in 21.5. In 21.5, Silence-Message is applied only
to write-region, while in this patch, I simply substituted
Silence-Message for its expansion to a flet. (I would have done the
same as in 21.5, but that hunk failed to apply, so I did the less
invasive change, which avoids a bunch of spurious whitespace change.)
Rationale is provided in the posts referenced above.
Index: tests/ChangeLog
===================================================================
RCS file:
/Users/steve/Software/Repositories/cvs.xemacs.org/XEmacs/xemacs/tests/ChangeLog,v
retrieving revision 1.2.2.44
diff -u -r1.2.2.44 ChangeLog
--- tests/ChangeLog 29 Jan 2006 00:00:56 -0000 1.2.2.44
+++ tests/ChangeLog 24 Jun 2006 14:31:55 -0000
@@ -0,0 +1,11 @@
+2006-06-24 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * automated/test-harness.el (Silence-Message): New macro.
+ * automated/mule-tests.el: Use it.
+ * automated/region-tests.el: Use it.
+ * automated/tag-tests.el: Use it.
+
+2006-06-24 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * automated/test-harness.el: Improve handling of unexpected errors.
+