Re: commit: Prevent integer overflow and subsequent crashes when attempting to load large

Monday, 24 August 2009

 Ar an ceathrú lá is fiche de mí Lúnasa, scríobh Jerry James: 

...
 We need to deal with two issues.  First is the missing (U)INT_64_BIT
 definition.  Thanks for the pointer, Aidan.  From looking at that, as
 well as a few other remarks about __int64 located with Google, it
 appears that this issue affects 32-bit Windows platforms exclusively.
 I think we can probably get away with just checking for __WIN32__,
 rather than piling on check after check for particular compilers on
 that platform. 
__WIN32__ isn’t defined on my particular native compiler (Visual C++ 2005
Express Edition, with Microsoft Platform SDK for Windows Server 2003 SP1). I
can use WIN32_ANY, from our include files, instead, and compilation goes
ahead successfully.

...
 Second is the warning.  Since we already check that the results of
the
 image size calculation fit into a size_t, the only real problem here
 is that I forgot to cast to a size_t in one place.

 So I think this patch fixes both issues.  Can somebody try it and tell
 me yea or nay? 
Yea on the first bit; I haven’t gone to the trouble of creating a corrupt
TIFF image that would trigger the second, please post one if you have it
around.

-- 
¿Dónde estará ahora mi sobrino Yoghurtu Nghe, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?

_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003