Ar an seachtú lá is fiche de mí na Samhain, scríobh Vin Shelton:
I think this patch triggered another one of the VC6 infelicities:
Bah. Thanks, Vin; I’ve just committed something that eliminates the relevant
warning on GCC and should eliminate the build failure. Shout if it doesn’t.
(I suppose this is a helpful reminder for other C work I’m doing at the
moment, which I’ve been mostly building with G++. Now if there were only a
compile-time switch where G++ would warn about statements before
declarations ...)
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1291122524 0
# Node ID c290121b0c3f858e848492ebd776b9891d24e37c
# Parent 17c381a2f377655bd241d72fda5fca656fa67104
#'fill; move all declarations before statements, for the Visual Studio build
2010-11-30 Aidan Kehoe <kehoea(a)parhasard.net>
* fns.c (Ffill):
Move all declarations before statements, for the sake of the
Visual Studio build. Thank you Vin!
diff -r 17c381a2f377 -r c290121b0c3f src/ChangeLog
--- a/src/ChangeLog Wed Nov 24 17:54:57 2010 +0000
+++ b/src/ChangeLog Tue Nov 30 13:08:44 2010 +0000
@@ -1,3 +1,9 @@
+2010-11-30 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * fns.c (Ffill):
+ Move all declarations before statements, for the sake of the
+ Visual Studio build. Thank you Vin!
+
2010-11-24 Aidan Kehoe <kehoea(a)parhasard.net>
* font-mgr.c (Ffc_pattern_get): Fix my last change when both
diff -r 17c381a2f377 -r c290121b0c3f src/fns.c
--- a/src/fns.c Wed Nov 24 17:54:57 2010 +0000
+++ b/src/fns.c Tue Nov 30 13:08:44 2010 +0000
@@ -4173,11 +4173,13 @@
{
Lisp_Object sequence = args[0];
Lisp_Object item = args[1];
- Elemcount starting = 0, ending = EMACS_INT_MAX + 1, ii, len;
+ Elemcount starting, ending = EMACS_INT_MAX + 1, ii, len;
PARSE_KEYWORDS (Ffill, nargs, args, 2, (start, end), (start = Qzero));
CHECK_NATNUM (start);
+ starting = BIGNUMP (start) ? EMACS_INT_MAX + 1 : XINT (start);
+
if (!NILP (end))
{
CHECK_NATNUM (end);
@@ -4201,7 +4203,6 @@
check_sequence_range (sequence, start, end, make_int (len));
ending = min (ending, len);
- starting = XINT (start);
for (ii = starting; ii < ending; ++ii)
{
@@ -4220,7 +4221,6 @@
check_sequence_range (sequence, start, end, make_int (len));
ending = min (ending, len);
- starting = XINT (start);
for (ii = starting; ii < ending; ++ii)
{
@@ -4230,7 +4230,6 @@
else if (LISTP (sequence))
{
Elemcount counting = 0;
- starting = BIGNUMP (start) ? EMACS_INT_MAX + 1 : XINT (start);
EXTERNAL_LIST_LOOP_3 (elt, sequence, tail)
{
--
“Apart from the nine-banded armadillo, man is the only natural host of
Mycobacterium leprae, although it can be grown in the footpads of mice.”
-- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches