Re: [PATCH] package sh-script executable.el (executable-interpret): parameter correction
Jerry James wrote:
On Sat, Mar 15, 2008 at 2:37 AM, It's me FKtPp ;)
<m_pupil(a)yahoo.com.cn> wrote:
> Dear Reviewers,
>
> Do you think the following changelog and patch are acceptable to be
> commited?
>
Make the string "No more errors" instead. Also, could you insert a
comment just above the compile-internal invocation stating something
like this:
;; XEmacs change: arguments to compile-internal differ from Emacs
That way we we're less likely to lose your fix on the next sync with
Emacs. Thanks for catching this!
Okay, I've done done modification as you described.
Please find below the patch...
Thanks,
FKtPp
ChangeLog addition:
2008-03-19 It's me FKtPp ;) <m_pupil(a)yahoo.com.cn>
* ChangeLog:
* executable.el (executable-interpret):
sh-script[Packages] source patch:
Diff command: cvs -q diff -u
Files affected: executable.el
===================================================================
RCS ChangeLog
===================================================================
RCS
Index: ChangeLog
===================================================================
RCS file:
/pack/xemacscvs/XEmacs/packages/xemacs-packages/sh-script/ChangeLog,v
retrieving revision 1.30
diff -u -r1.30 ChangeLog
--- ChangeLog 2008/02/10 19:09:00 1.30
+++ ChangeLog 2008/03/19 13:18:20
＠＠ -1,3 +1,8 ＠＠
+2008-03-15 It's me FKtPp ;) <m_pupil(a)yahoo.com.cn>
+
+ * executable.el (executable-interpret): Correct compile-internal's
+ parameters to avoid error when `C-c C-x'(executable-interpret).
+
2008-02-10 Norbert Koch <viteno(a)xemacs.org>
* Makefile (VERSION): XEmacs package 1.23 released.
Index: executable.el
===================================================================
RCS file:
/pack/xemacscvs/XEmacs/packages/xemacs-packages/sh-script/executable.el,v
retrieving revision 1.4
diff -u -r1.4 executable.el
--- executable.el 2005/10/15 21:27:07 1.4
+++ executable.el 2008/03/19 13:18:20
＠＠ -223,9 +223,13 ＠＠
(save-some-buffers (not compilation-ask-about-save))
(set (make-local-variable 'executable-command) command)
(let ((compilation-error-regexp-alist executable-error-regexp-alist))
- (compile-internal command t (lambda (x) "*interpretation*"))))
-
-
+ ;; XEmacs change: arguments to compile-internal differ from Emacs
+ (compile-internal command
+ "No more errors"
+ nil
+ nil
+ nil
+ (lambda (x) "*interpretation*"))))
;;;###autoload
(defun executable-set-magic (interpreter &optional argument
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches