Re: [PATCH 21.5] Add ID-FORMAT to file-attributes (Suggestions are welcome)
>>>> Stephen J Turnbull <stephen(a)xemacs.org> writes:
Note that the second argument is optional.
I know. Is the DEFUN right?
I assume the "we plan to change that" statement comes from
GNU?
Yes. That paragraph about the ID-FORMAT argument is taken verbatim
from GNU.
But before that happens, we'd want to have a period where the
second
attribute is mandatory, so I don't think we need that statement. I
also have to wonder if it will actually happen.
Hmm.. I suggest just drop everything about future changes. This is a
compatibility change.
Do you know if there was any discussion about alternative changes to
the API,
I don't know. Just stumbled on this incompatibility when trying to
make other code work with XEmacs. So I know nothing about history.
I think we should consider a more coherent API (which,
unfortunately, would need a new name) on the following principles:
And then provide a file-attribute compatibility function?
As you suspected, this is horrible.
Well I did not suspected anything. Just that I did not understand the
code (mostly because I don't know the internals at all so well.) These
file handlers sort of popped up out of the blue but maybe I didn't
look around close enough.
New file?
Yes. I always try to add a unit test if that is possible.
Ask Mike if he has any tests that could be converted for use here.
Yes, I'll do that.
Yours
--
%% Mats
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches