QUERY
>>>> "sjt" == Stephen J Turnbull
<stephen(a)xemacs.org> writes:
sjt> It's going to be about a week before I can review it, but
sjt> I'll apply it in my working copies (Mac OS X/PPC and Linux).
The patch doesn't apply for me, some internal whitespace goes missing
in the original text of one of the comments on the CCL grammar. I'm
not sure where the problem is.
There's trailing whitespace all over the place; it's quite obvious if
you look at the email patch without qp-decoding it.
To compile, I needed a couple of additional EXFUNs in lisp.h; you seem
to have EXFUNed functions in charset.h and maybe elsewhere, but
unfortunately that doesn't seem to get included where it's needed.
I personally think that EXFUNing anywhere but in lisp.h is a bad idea.
It's not clear to me that it's a good idea to be calling Lisp
functions from this code. Lisp may signal if it doesn't like the
arguments, or randomly collect garbage, and other antisocial habits.
The patch to unicode.el apparently went missing, so the needed CCL
program(s) never get defined and registered.
It's not clear to me that it's a good idea to use CCL at all. If we
are going to continue to do so, we should change the source language
to Lisp and just signal an error if the compilation fails (optionally
we could allow a Lisp program wherever a CCL program is permitted).
--
School of Systems and Information Engineering
http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.