Re: [PATCH 21.5] Add ID-FORMAT to file-attributes (Suggestions are welcome)
Mats Lidell <matsl(a)xemacs.org> writes:
Hi,
Hi Mats,
Apart from that I wonder about the code that does call2 and call3 in
the "if (!NILP (handler))"-part. What is the !NILP (handler)-stuff?
and is the call2 and call3 appropriate? The later is taken verbatim
from GNU that has the same construction. (But it feel bad not knowing
a thing about what is going on ;-)
＠＠ -858,7 +868,10 ＠＠
if (!NILP (handler))
{
UNGCPRO;
- return call2 (handler, Qfile_attributes, filename);
+ if (NILP(id_format))
+ return call2 (handler, Qfile_attributes, filename);
+ else
+ return call3 (handler, Qfile_attributes, filename, id_format);
}
It's about backward compatibility. If id_format is NIL one uses call2,
in order to run also file name handlers which are not aware of the new
parameter.
I don't believe it is still necessary these days; file name handlers
shall know the id_format parameter meanwhile.
FWIW, Tramp does. Also does ange-ftp. But I don't know, whether efs is
aware of, to give you an XEmacs related example.
Your // Mats
Best regards, Michael.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches