[Q21.5] Incremental Garbage Collector (revised)

QUERY There are some things that need to be resolved before I can roll a release. +if test "$have_vdb_fake" = yes && test "$enable_vdb" != fake; then + echo " WARNING: ---------------------------------------------------------" + echo " WARNING: The new incremental garbage collector is enabled, but" + echo " WARNING: a virtual dirty bit implementation is not yet available" + echo " WARNING: on this system. XEmacs will crash if you try to switch on" + echo " WARNUNG: incremental garbage collection!" + echo " WARNING: Use \`--disable-newgc' to turn incremental gc off." + echo " WARNING: ---------------------------------------------------------" +fi Why doesn't this case XE_DIE? If there's a reason why developers would want this, there needs to be an option to enable it. We should _never_ allow an autodetected configuration that contains a crash we know how to prevent. On review, that's the only thing that needs to be resolved. Very nice! (I know you don't promise it works yet, but it really shouldn't affect anybody who doesn't use the new features.) Everything else is #ifdef'd (except for a couple of minor things like the debugger init files, and people who use those can deal with any issues). However, I would like to ask about the extreme repetitiveness of the patch; is there no way to use macro magic to avoid all of those (some hunk) #ifdef NEW_GC /* a couple lines of code */ #else /* NEW_GC */ (next hunk) #endif /* NEW_GC */ ? -- School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.