X-Sent: 48 weeks, 3 days, 22 hours, 38 minutes, 27 seconds ago This has got to be a record for the longest time taken to follow up on a post. I suppose "sorry" probably wouldn't cut it in this case. I could sacrifice my first born if you like, no, hang on, on 2nd thoughts, how about my ex-wife? At the very least, please accept my most sincere and humblest apologies. Do you even remember posting this? |--==> "n" == nbecker <nbecker(a)fred.net&gt; writes: n> I marked a bunch of files in pcl-cvs mode. Then I chose "undo n> changes" from the menu. It prompts "Delete 8 files?". Rather n> misleading. Actually, this is correct behaviour. The menu item "undo changes" runs 'cvs-mode-undo', that function undoes all the local changes to the marked files in the PCL-CVS buffer. It does it by deleting the local file and then runs 'cvs update FILE'. So when it asks you "Delete x files?" that's exactly what it is going to do. Well, that's what I get from the doc string of 'cvs-mode-undo'. ,---- | (defun-cvs-mode (cvs-mode-undo . SIMPLE) (flags) | "Undo local changes to all marked files. | The file is removed and `cvs update FILE' is run." `---- -- |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---| | XEmacs - It's not just an editor. | | It's a way of life. | |------------------------------------&lt;youngs(a)xemacs.org&gt;---|

|--==> "n" == nbecker <nbecker(a)fred.net&gt; writes: n> I marked a bunch of files in pcl-cvs mode. Then I chose "undo n> changes" from the menu. It prompts "Delete 8 files?". Rather n> misleading. SY> Actually, this is correct behaviour. The menu item "undo changes" SY> runs 'cvs-mode-undo', that function undoes all the local changes to SY> the marked files in the PCL-CVS buffer. It does it by deleting the SY> local file and then runs 'cvs update FILE'. n> It may be literally correct, but I was surprised and confused by this n> question. I wasn't quite sure whether it was doing just what you n> describe, or whether it had gone insane and was offering to delete 8 n> files at random. IIRC, it didn't tell me which 8 files it wanted to n> delete, which didn't help either. Do you think it would be better and less confusing if you were prompted with something like "Delete local copy of marked files and re check them out of CVS?"? Or words to that effect? -- |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---| | XEmacs - It's not just an editor. | | It's a way of life. | |------------------------------------&lt;youngs(a)xemacs.org&gt;---|

On Tue, 18 Dec 2001, Steve Youngs wrote: [] What about a shorter one, say "Revert 8 files from CVS?". It looks more like what you get from a M-x revert-buffer. Maybe a cvs-mode-revert alias to cvs-mode-undo would be appropriate? (just a thought) Jarl

SY> |--==> "n" == nbecker <nbecker(a)fred.net&gt; writes: >> n> I marked a bunch of files in pcl-cvs mode. Then I chose "undo n> changes" from the menu. It prompts "Delete 8 files?". Rather n> misleading. SY> Actually, this is correct behaviour. The menu item "undo changes" SY> runs 'cvs-mode-undo', that function undoes all the local changes to SY> the marked files in the PCL-CVS buffer. It does it by deleting the SY> local file and then runs 'cvs update FILE'. n> It may be literally correct, but I was surprised and confused by this n> question. I wasn't quite sure whether it was doing just what you n> describe, or whether it had gone insane and was offering to delete 8 n> files at random. IIRC, it didn't tell me which 8 files it wanted to n> delete, which didn't help either. SY> Do you think it would be better and less confusing if you were SY> prompted with something like "Delete local copy of marked SY> files and re check them out of CVS?"? Or words to that SY> effect? Hi Steve, I hate the current behavior for the reasons given above. It's confusing. It does not provide any information about the files affected. I think completion buffer feedback, along the lines of what d runs the command dired-flag-file-deletion and x runs the command dired-expunge-deletions do, would be much better. Stealing from (defun-cvs-mode (cvs-mode-undo . SIMPLE) (flags) in pcl-cvs.el I would reword the message to: "Undo local changes?" The other gripe I have about this command is that it's not bound to a key, right? No, actually it is on cvs-mode-undo is on undo, U, C-/, C-_ so my gripe is that it shows up as bound to undo on the menu. I didn't realize for many months now, that this "undo" means: Same key-binding as "undo" command. How can we get "U" in the menu istead? Other than that, I love PCV-CVS. Best regards, Adrian SY> -- SY> |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---| SY> | XEmacs - It's not just an editor. | SY> | It's a way of life. | SY> |------------------------------------&lt;youngs(a)xemacs.org&gt;---| -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/

APA> Other than that, I love PCV-CVS. Actually I was talking about PCL-CVS. -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/

Jarl> On 17 Dec 2001, Adrian Aichner wrote: SY> |--==> "n" == nbecker <nbecker(a)fred.net&gt; writes: n> I marked a bunch of files in pcl-cvs mode. Then I chose "undo n> changes" from the menu. It prompts "Delete 8 files?". Rather n> misleading. SY> Actually, this is correct behaviour. The menu item "undo changes" SY> runs 'cvs-mode-undo', that function undoes all the local changes to SY> the marked files in the PCL-CVS buffer. It does it by deleting the SY> local file and then runs 'cvs update FILE'. n> It may be literally correct, but I was surprised and confused by this n> question. I wasn't quite sure whether it was doing just what you n> describe, or whether it had gone insane and was offering to delete 8 n> files at random. IIRC, it didn't tell me which 8 files it wanted to n> delete, which didn't help either. SY> Do you think it would be better and less confusing if you were SY> prompted with something like "Delete local copy of marked SY> files and re check them out of CVS?"? Or words to that SY> effect? >> Hi Steve, >> I hate the current behavior for the reasons given above. >> It's confusing. >> It does not provide any information about the files affected. Jarl> What about make it look similar to when committing, except Jarl> the message entering part. After entering a message and hit Jarl> C-c C-c a small buffer called *cvs-edit-files* comes up with Jarl> a list of the files affected and you are prompted "Really Jarl> commit? (y or n)", similarly cvs-mode-undo could come up Jarl> with a *cvs-edit-files* buffer listing the files affected, Jarl> and ask something like "Really undo ? (y or n)" or "Really Jarl> revert from CVS? (y or n)" I suggest *not* to use "Really Jarl> delete ? (y or n)" for reasons given below. This is basically what I called "completion buffer feedback". Jarl> In both cases the prompt could be improoved to contain the number of Jarl> files, such as "Really commit 8 files (y or n)?". >> I think completion buffer feedback, along the lines of what >> d runs the command dired-flag-file-deletion >> and >> x runs the command dired-expunge-deletions >> do, would be much better. Jarl> I am not sure I get you right, I guess you want behaviour Jarl> similar to deletion of files (in `dired') and buffers (in Jarl> `list-buffers'). I pointed out an example of the UI I have in mind. I don't want to know whether 894 or 895 files are going to be reverted, I wnat to see what their names are. Jarl> I don't think it's a good idea to think of the cvs-mode-undo Jarl> as a *deletion*, because the files are still there after a I don't think that either, that's why I suggested: If that message is no good, then the docstring of cvs-mode-undo should be changed also, that's my point. Jarl> cvs-mode-undo the content has just changed. I know that the Jarl> effect is delete-then-update, but from a users point of view Jarl> I think it more looks like an undo or a revert. Exactly. Jarl> and "yes" PCL-CVS is great! Jarl> Jarl -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/

SY> |--==> "APA" == Adrian Aichner <Adrian.Aichner(a)t-online.de&gt; writes: >> SY> Do you think it would be better and less confusing if you were SY> prompted with something like "Delete local copy of marked SY> files and re check them out of CVS?"? Or words to that SY> effect? APA> Hi Steve, APA> I hate the current behavior for the reasons given above. APA> It's confusing. APA> It does not provide any information about the files affected. APA> I think completion buffer feedback, along the lines of what APA> d runs the command dired-flag-file-deletion APA> and APA> x runs the command dired-expunge-deletions APA> do, would be much better. SY> Yeah, it might be at that. I'll have to go lurking through the Dired SY> code. Wanna help? Sure. The list of files would be displayed when setting `cvs-confirm-removals' (buffer: pcl-cvs.el, mode: Emacs-Lisp) Customizable user variable: value: list *Ask for confirmation before removing files. Non-nil means that PCL-CVS will ask confirmation before removing files except for files whose content can readily be recovered from the repository. A value of LIST means that the list of files to be deleted will be displayed when asking for confirmation. The default value is t. However, a bug is lurking in that code. See xemacs-patches for a fix in about 10 minutes. Adrian APA> The other gripe I have about this command is that it's not bound to a APA> key, right? APA> No, actually it is on APA> cvs-mode-undo is on undo, U, C-/, C-_ APA> so my gripe is that it shows up as bound to undo on the menu. APA> I didn't realize for many months now, that this "undo" means: APA> Same key-binding as "undo" command. APA> How can we get "U" in the menu istead? SY> Not sure at the moment, but it has gotta be possible. APA> Other than that, I love PCV-CVS. SY> Me too, use it all the time. But here's another gripe... SY> Try 'M-x find-function RET cvs-mode-undo RET' SY> 'find-function' knows that it is in 'pcl-cvs.el' but it can't find the SY> function within that file. Is it because of 'defun-cvs-mode' instead SY> of 'defun'? Can that be made to work? I don't know off hand. SY> -- SY> |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---| SY> | XEmacs - It's not just an editor. | SY> | It's a way of life. | SY> |------------------------------------&lt;youngs(a)xemacs.org&gt;---| -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/